From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH] drm/tilcdc: panel: Add tilcdc- prefix to driver name Date: Thu, 20 Aug 2015 12:20:52 +0300 Message-ID: <55D59BF4.2080505@ti.com> References: <1438164750-893-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1793622956==" Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95D446E180 for ; Thu, 20 Aug 2015 02:20:56 -0700 (PDT) In-Reply-To: <1438164750-893-1-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1793622956== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cnuhvLX5qhH1MWf6o4WgBiS9Ex0WGBouq" --cnuhvLX5qhH1MWf6o4WgBiS9Ex0WGBouq Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 29/07/15 13:12, Thierry Reding wrote: > From: Thierry Reding >=20 > The current driver name, "panel", is very generic. This causes problems= > when the driver is enabled on non-TI device tree platforms if the panel= > node is called "panel". This causes the driver name match fall-back in > platform_match() to succeed, even if some other driver would precisely > match using the OF device ID table, for example. >=20 > Currently there don't seem to be any in-tree users that rely on the > driver name match, so adding the prefix should be safe. >=20 > Signed-off-by: Thierry Reding > --- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/ti= lcdc/tilcdc_panel.c > index 7a0315855e90..375505caf9c7 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > @@ -460,7 +460,7 @@ struct platform_driver panel_driver =3D { > .remove =3D panel_remove, > .driver =3D { > .owner =3D THIS_MODULE, > - .name =3D "panel", > + .name =3D "tilcdc-panel", > .of_match_table =3D panel_of_match, > }, > }; I didn't know we do matching based on the node name also... This looks fine, I believe the tilcdc is only used with DT based systems. I'll pick this up. Tomi --cnuhvLX5qhH1MWf6o4WgBiS9Ex0WGBouq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJV1Zv0AAoJEPo9qoy8lh716XYP/RHadHCXEjLVfRlUNDT+E6lI XVNfB2bqjfAsKFGAEwAB3gWFHq47f73/1hKUCEuT+HZagoOeWG57LzL8Sbw1x53d ei6e8AqgMgdhOy2zk/jY/WNMHs1vLzVrZRmuxK13iqmSzbjw0KFlIxZx7ueLS8T5 QvPYMsX9I55+s32++ciWEB1PDDxQGC/egz22ljfBtWT692ZsoiAwI+px8T3xIpv7 a35sH0HGBXwt+H3lG7N9Hj6QXUX6fa5rD3n/AJyBx/016YDPmPBYfhq9EsbjUxWY LXNqckqMUgVHdwX6e38xI/rxwAte7OM01qo7lmDm1GRSSo9jTv/Y/5eTs1LdlaP0 fAe3zm26bCkfEZ1JA+huMNDRYjmqqPhesrnK7DCW3pGDPI5BCFgySkBHEdvnRPQU uZTS/B/w3SNxNEzE1+8EoMrnYgtponQYNtn/P9Jb3QqVNNNvJ6rXfVMJAiUHDjQV 9QbWLy6WU3pRnZVAEnZXz5YFfCG8nzmtmJ0lFcqSvk3VYrqOC96bs7Yle0Cgadbi I/ogvlKqr6H1WJtppVsDldBxY5cQedBJiQ/9lucThKh+EcmJ6th8zxlAPV4AdSbG slL4Chrp+onHu2oMXGL1z5GiTc34n5mx/zHF593TL050VYO39n2pofMZ8IvKbMGP MlJtT97uJM2l8q5K8cNE =bwoo -----END PGP SIGNATURE----- --cnuhvLX5qhH1MWf6o4WgBiS9Ex0WGBouq-- --===============1793622956== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1793622956==--