From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shannon Zhao <shannon.zhao@linaro.org>
Subject: Re: Design doc of adding ACPI support for arm64 on Xen
 - version 4
Date: Thu, 20 Aug 2015 19:22:08 +0800
Message-ID: <55D5B860.9070307@linaro.org>
References: <55D472D4.9010007@huawei.com> <55D49AA1.3030702@citrix.com>
	<55D54483.5000103@huawei.com> <55D58DD9.9090500@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55D58DD9.9090500@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: =?windows-1252?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Shannon Zhao <zhaoshenglong@huawei.com>, xen-devel <xen-devel@lists.xen.org>, Christoffer Dall <christoffer.dall@linaro.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Julien Grall <julien.grall@citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Jan Beulich <jbeulich@suse.com>, Parth Dixit <parth.dixit@linaro.org>, andrew@fubar.geek.nz, Boris Ostrovsky <boris.ostrovsky@oracle.com>, David Vrabel <david.vrabel@citrix.com>
Cc: Hangaohuai <hangaohuai@huawei.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>
List-Id: xen-devel@lists.xenproject.org

Hi Roger,

On 2015/8/20 16:20, Roger Pau Monn=E9 wrote:
> El 20/08/15 a les 5.07, Shannon Zhao ha escrit:
>> On 2015/8/19 23:02, Roger Pau Monn=E9 wrote:
>>> El 19/08/15 a les 14.13, Shannon Zhao ha escrit:
>>>> XENMAPSPACE "XENMAPSPACE_dev_mmio". The usage of this hypercall
>>>> parameters:
>>>> - domid: DOMID_SELF.
>>>> - space: XENMAPSPACE_dev_mmio.
>>>> - gpfns: guest physical addresses where the mapping should appear.
>>>
>>> This is not complete, you have forgotten to add the idxs field,
>>
>> Sorry, I didn't use the idx for the mmio region mapping. What's the idx
>> useful for here?
>
> I've already posted this in the previous version, and you agreed on the
> interface and the usage of the fields, please see:
>
> http://marc.info/?l=3Dxen-devel&m=3D143986236212359
>
> The idxs field is explicitly mentioned there with it's usage.
>

Yeah, I said I will add the description of hypercall parameters.
It seems that we are talking about a different parameter.
To map the mmio region, I reuse the struct xen_add_to_physmap and there =

is idx not idxs. Everytime Dom0 maps one page and it's mapped 1:1(guest =

physical address is same with real physical hardware address), so it =

only needs to tell the hypervisor the gpfn.

Since I'm not familiar with Xen general approach, if this is not right, =

please fix me.

Thanks,
-- =

Shannon