From: David Vrabel <david.vrabel@citrix.com>
To: Murilo Opsfelder Araujo <mopsfelder@gmail.com>,
<linux-kernel@vger.kernel.org>, <xen-devel@lists.xenproject.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Julien Grall <julien.grall@citrix.com>,
"Stefano Stabellini" <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()
Date: Thu, 20 Aug 2015 12:27:11 +0100 [thread overview]
Message-ID: <55D5B98F.4060607@citrix.com> (raw)
In-Reply-To: <1439990719-19517-1-git-send-email-mopsfelder@gmail.com>
On 19/08/15 14:25, Murilo Opsfelder Araujo wrote:
> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
> xen_tmem_get_page() receiving pfn instead of page.
>
> This change also fixes the following build warning:
>
> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
> drivers/xen/tmem.c:194:47: warning: passing argument 4 of ‘xen_tmem_get_page’ makes pointer from integer without a cast
> ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
> ^
> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of type ‘long unsigned int’
> static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
I've folded this in, thanks.
David
next prev parent reply other threads:[~2015-08-20 11:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 13:25 [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() Murilo Opsfelder Araujo
2015-08-20 0:23 ` Julien Grall
2015-08-20 0:23 ` Julien Grall
2015-08-22 14:51 ` Murilo Opsfelder Araújo
2015-08-22 14:51 ` Murilo Opsfelder Araújo
2015-08-20 11:27 ` David Vrabel
2015-08-20 11:27 ` David Vrabel [this message]
2015-08-22 14:52 ` Murilo Opsfelder Araújo
2015-08-22 14:52 ` Murilo Opsfelder Araújo
-- strict thread matches above, loose matches on Subject: below --
2015-08-19 13:25 Murilo Opsfelder Araujo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D5B98F.4060607@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=julien.grall@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mopsfelder@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.