* [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()
@ 2015-08-19 13:25 Murilo Opsfelder Araujo
2015-08-20 0:23 ` Julien Grall
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Murilo Opsfelder Araujo @ 2015-08-19 13:25 UTC (permalink / raw)
To: linux-kernel, xen-devel
Cc: Konrad Rzeszutek Wilk, Boris Ostrovsky, Julien Grall,
Stefano Stabellini, David Vrabel, Murilo Opsfelder Araujo
The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
xen_tmem_get_page() receiving pfn instead of page.
This change also fixes the following build warning:
drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
drivers/xen/tmem.c:194:47: warning: passing argument 4 of ‘xen_tmem_get_page’ makes pointer from integer without a cast
ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
^
drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of type ‘long unsigned int’
static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
^
Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
---
drivers/xen/tmem.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/xen/tmem.c b/drivers/xen/tmem.c
index b0c895e..945fc43 100644
--- a/drivers/xen/tmem.c
+++ b/drivers/xen/tmem.c
@@ -183,7 +183,6 @@ static int tmem_cleancache_get_page(int pool, struct cleancache_filekey key,
{
u32 ind = (u32) index;
struct tmem_oid oid = *(struct tmem_oid *)&key;
- unsigned long pfn = page_to_pfn(page);
int ret;
/* translate return values to linux semantics */
@@ -191,7 +190,7 @@ static int tmem_cleancache_get_page(int pool, struct cleancache_filekey key,
return -1;
if (ind != index)
return -1;
- ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
+ ret = xen_tmem_get_page((u32)pool, oid, ind, page);
if (ret == 1)
return 0;
else
--
2.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()
2015-08-19 13:25 [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() Murilo Opsfelder Araujo
@ 2015-08-20 0:23 ` Julien Grall
2015-08-20 0:23 ` Julien Grall
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: Julien Grall @ 2015-08-20 0:23 UTC (permalink / raw)
To: Murilo Opsfelder Araujo, linux-kernel, xen-devel
Cc: Boris Ostrovsky, Stefano Stabellini, David Vrabel
Hi,
On 19/08/2015 06:25, Murilo Opsfelder Araujo wrote:
> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
> xen_tmem_get_page() receiving pfn instead of page.
>
> This change also fixes the following build warning:
>
> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
> drivers/xen/tmem.c:194:47: warning: passing argument 4 of ‘xen_tmem_get_page’ makes pointer from integer without a cast
> ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
> ^
> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of type ‘long unsigned int’
> static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
> ^
>
> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
Sorry for the breakage, I haven't spot it because CONFIG_CLEANCACHE is
not enabled on my config.
Reviewed-by: Julien Grall <julien.grall@citrix.com>
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()
2015-08-19 13:25 [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() Murilo Opsfelder Araujo
2015-08-20 0:23 ` Julien Grall
@ 2015-08-20 0:23 ` Julien Grall
2015-08-22 14:51 ` Murilo Opsfelder Araújo
2015-08-22 14:51 ` Murilo Opsfelder Araújo
2015-08-20 11:27 ` David Vrabel
2015-08-20 11:27 ` David Vrabel
3 siblings, 2 replies; 10+ messages in thread
From: Julien Grall @ 2015-08-20 0:23 UTC (permalink / raw)
To: Murilo Opsfelder Araujo, linux-kernel, xen-devel
Cc: Konrad Rzeszutek Wilk, Boris Ostrovsky, Stefano Stabellini,
David Vrabel
Hi,
On 19/08/2015 06:25, Murilo Opsfelder Araujo wrote:
> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
> xen_tmem_get_page() receiving pfn instead of page.
>
> This change also fixes the following build warning:
>
> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
> drivers/xen/tmem.c:194:47: warning: passing argument 4 of ‘xen_tmem_get_page’ makes pointer from integer without a cast
> ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
> ^
> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of type ‘long unsigned int’
> static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
> ^
>
> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
Sorry for the breakage, I haven't spot it because CONFIG_CLEANCACHE is
not enabled on my config.
Reviewed-by: Julien Grall <julien.grall@citrix.com>
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()
2015-08-20 0:23 ` Julien Grall
@ 2015-08-22 14:51 ` Murilo Opsfelder Araújo
2015-08-22 14:51 ` Murilo Opsfelder Araújo
1 sibling, 0 replies; 10+ messages in thread
From: Murilo Opsfelder Araújo @ 2015-08-22 14:51 UTC (permalink / raw)
To: Julien Grall
Cc: Stefano Stabellini, Linux Kernel Mailing List, David Vrabel,
xen-devel, Boris Ostrovsky
On Wed, Aug 19, 2015 at 9:23 PM, Julien Grall <julien.grall@citrix.com> wrote:
> Hi,
>
> On 19/08/2015 06:25, Murilo Opsfelder Araujo wrote:
>>
>> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
>> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
>> xen_tmem_get_page() receiving pfn instead of page.
>>
>> This change also fixes the following build warning:
>>
>> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
>> drivers/xen/tmem.c:194:47: warning: passing argument 4 of
>> ‘xen_tmem_get_page’ makes pointer from integer without a cast
>> ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
>> ^
>> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is
>> of type ‘long unsigned int’
>> static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
>> ^
>>
>> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
>
>
> Sorry for the breakage, I haven't spot it because CONFIG_CLEANCACHE is not
> enabled on my config.
>
> Reviewed-by: Julien Grall <julien.grall@citrix.com>
>
> Regards,
>
> --
> Julien Grall
Hi, Julien.
No need to apologize, and thanks for reviewing that.
--
Murilo
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()
2015-08-20 0:23 ` Julien Grall
2015-08-22 14:51 ` Murilo Opsfelder Araújo
@ 2015-08-22 14:51 ` Murilo Opsfelder Araújo
1 sibling, 0 replies; 10+ messages in thread
From: Murilo Opsfelder Araújo @ 2015-08-22 14:51 UTC (permalink / raw)
To: Julien Grall
Cc: Linux Kernel Mailing List, xen-devel, Konrad Rzeszutek Wilk,
Boris Ostrovsky, Stefano Stabellini, David Vrabel
On Wed, Aug 19, 2015 at 9:23 PM, Julien Grall <julien.grall@citrix.com> wrote:
> Hi,
>
> On 19/08/2015 06:25, Murilo Opsfelder Araujo wrote:
>>
>> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
>> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
>> xen_tmem_get_page() receiving pfn instead of page.
>>
>> This change also fixes the following build warning:
>>
>> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
>> drivers/xen/tmem.c:194:47: warning: passing argument 4 of
>> ‘xen_tmem_get_page’ makes pointer from integer without a cast
>> ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
>> ^
>> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is
>> of type ‘long unsigned int’
>> static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
>> ^
>>
>> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
>
>
> Sorry for the breakage, I haven't spot it because CONFIG_CLEANCACHE is not
> enabled on my config.
>
> Reviewed-by: Julien Grall <julien.grall@citrix.com>
>
> Regards,
>
> --
> Julien Grall
Hi, Julien.
No need to apologize, and thanks for reviewing that.
--
Murilo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()
2015-08-19 13:25 [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() Murilo Opsfelder Araujo
2015-08-20 0:23 ` Julien Grall
2015-08-20 0:23 ` Julien Grall
@ 2015-08-20 11:27 ` David Vrabel
2015-08-20 11:27 ` David Vrabel
3 siblings, 0 replies; 10+ messages in thread
From: David Vrabel @ 2015-08-20 11:27 UTC (permalink / raw)
To: Murilo Opsfelder Araujo, linux-kernel, xen-devel
Cc: Julien Grall, Boris Ostrovsky, Stefano Stabellini
On 19/08/15 14:25, Murilo Opsfelder Araujo wrote:
> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
> xen_tmem_get_page() receiving pfn instead of page.
>
> This change also fixes the following build warning:
>
> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
> drivers/xen/tmem.c:194:47: warning: passing argument 4 of ‘xen_tmem_get_page’ makes pointer from integer without a cast
> ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
> ^
> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of type ‘long unsigned int’
> static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
I've folded this in, thanks.
David
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()
2015-08-19 13:25 [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() Murilo Opsfelder Araujo
` (2 preceding siblings ...)
2015-08-20 11:27 ` David Vrabel
@ 2015-08-20 11:27 ` David Vrabel
2015-08-22 14:52 ` Murilo Opsfelder Araújo
2015-08-22 14:52 ` Murilo Opsfelder Araújo
3 siblings, 2 replies; 10+ messages in thread
From: David Vrabel @ 2015-08-20 11:27 UTC (permalink / raw)
To: Murilo Opsfelder Araujo, linux-kernel, xen-devel
Cc: Konrad Rzeszutek Wilk, Boris Ostrovsky, Julien Grall,
Stefano Stabellini
On 19/08/15 14:25, Murilo Opsfelder Araujo wrote:
> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
> xen_tmem_get_page() receiving pfn instead of page.
>
> This change also fixes the following build warning:
>
> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
> drivers/xen/tmem.c:194:47: warning: passing argument 4 of ‘xen_tmem_get_page’ makes pointer from integer without a cast
> ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
> ^
> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of type ‘long unsigned int’
> static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
I've folded this in, thanks.
David
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()
2015-08-20 11:27 ` David Vrabel
@ 2015-08-22 14:52 ` Murilo Opsfelder Araújo
2015-08-22 14:52 ` Murilo Opsfelder Araújo
1 sibling, 0 replies; 10+ messages in thread
From: Murilo Opsfelder Araújo @ 2015-08-22 14:52 UTC (permalink / raw)
To: David Vrabel
Cc: Linux Kernel Mailing List, xen-devel, Konrad Rzeszutek Wilk,
Boris Ostrovsky, Julien Grall, Stefano Stabellini
On Thu, Aug 20, 2015 at 8:27 AM, David Vrabel <david.vrabel@citrix.com> wrote:
> On 19/08/15 14:25, Murilo Opsfelder Araujo wrote:
>> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
>> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
>> xen_tmem_get_page() receiving pfn instead of page.
>>
>> This change also fixes the following build warning:
>>
>> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
>> drivers/xen/tmem.c:194:47: warning: passing argument 4 of ‘xen_tmem_get_page’ makes pointer from integer without a cast
>> ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
>> ^
>> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of type ‘long unsigned int’
>> static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
>
> I've folded this in, thanks.
>
> David
Thanks, David.
--
Murilo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()
2015-08-20 11:27 ` David Vrabel
2015-08-22 14:52 ` Murilo Opsfelder Araújo
@ 2015-08-22 14:52 ` Murilo Opsfelder Araújo
1 sibling, 0 replies; 10+ messages in thread
From: Murilo Opsfelder Araújo @ 2015-08-22 14:52 UTC (permalink / raw)
To: David Vrabel
Cc: Stefano Stabellini, Linux Kernel Mailing List, Julien Grall,
xen-devel, Boris Ostrovsky
On Thu, Aug 20, 2015 at 8:27 AM, David Vrabel <david.vrabel@citrix.com> wrote:
> On 19/08/15 14:25, Murilo Opsfelder Araujo wrote:
>> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
>> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
>> xen_tmem_get_page() receiving pfn instead of page.
>>
>> This change also fixes the following build warning:
>>
>> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
>> drivers/xen/tmem.c:194:47: warning: passing argument 4 of ‘xen_tmem_get_page’ makes pointer from integer without a cast
>> ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
>> ^
>> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of type ‘long unsigned int’
>> static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
>
> I've folded this in, thanks.
>
> David
Thanks, David.
--
Murilo
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()
@ 2015-08-19 13:25 Murilo Opsfelder Araujo
0 siblings, 0 replies; 10+ messages in thread
From: Murilo Opsfelder Araujo @ 2015-08-19 13:25 UTC (permalink / raw)
To: linux-kernel, xen-devel
Cc: Stefano Stabellini, Julien Grall, Murilo Opsfelder Araujo,
David Vrabel, Boris Ostrovsky
The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
xen_tmem_get_page() receiving pfn instead of page.
This change also fixes the following build warning:
drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
drivers/xen/tmem.c:194:47: warning: passing argument 4 of ‘xen_tmem_get_page’ makes pointer from integer without a cast
ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
^
drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of type ‘long unsigned int’
static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
^
Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
---
drivers/xen/tmem.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/xen/tmem.c b/drivers/xen/tmem.c
index b0c895e..945fc43 100644
--- a/drivers/xen/tmem.c
+++ b/drivers/xen/tmem.c
@@ -183,7 +183,6 @@ static int tmem_cleancache_get_page(int pool, struct cleancache_filekey key,
{
u32 ind = (u32) index;
struct tmem_oid oid = *(struct tmem_oid *)&key;
- unsigned long pfn = page_to_pfn(page);
int ret;
/* translate return values to linux semantics */
@@ -191,7 +190,7 @@ static int tmem_cleancache_get_page(int pool, struct cleancache_filekey key,
return -1;
if (ind != index)
return -1;
- ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
+ ret = xen_tmem_get_page((u32)pool, oid, ind, page);
if (ret == 1)
return 0;
else
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-08-22 14:52 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-19 13:25 [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() Murilo Opsfelder Araujo
2015-08-20 0:23 ` Julien Grall
2015-08-20 0:23 ` Julien Grall
2015-08-22 14:51 ` Murilo Opsfelder Araújo
2015-08-22 14:51 ` Murilo Opsfelder Araújo
2015-08-20 11:27 ` David Vrabel
2015-08-20 11:27 ` David Vrabel
2015-08-22 14:52 ` Murilo Opsfelder Araújo
2015-08-22 14:52 ` Murilo Opsfelder Araújo
-- strict thread matches above, loose matches on Subject: below --
2015-08-19 13:25 Murilo Opsfelder Araujo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.