From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [PATCH 3/4] [media] media: use entity.graph_obj.mdev instead of .parent Date: Thu, 20 Aug 2015 14:43:11 +0200 Message-ID: <55D5CB5F.2010106@xs4all.nl> References: <1439998526-12832-1-git-send-email-javier@osg.samsung.com> <1439998526-12832-4-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1439998526-12832-4-git-send-email-javier@osg.samsung.com> Sender: linux-sh-owner@vger.kernel.org To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: =?windows-1252?Q?S=F6ren_Brinkmann?= , devel@driverdev.osuosl.org, Kukjin Kim , linux-sh@vger.kernel.org, Mauro Carvalho Chehab , Hyun Kwon , Hans Verkuil , linux-samsung-soc@vger.kernel.org, Kyungmin Park , Krzysztof Kozlowski , "Prabhakar\"" , Greg Kroah-Hartman , Sylwester Nawrocki , Laurent Pinchart , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org On 08/19/15 17:35, Javier Martinez Canillas wrote: > The struct media_entity has a .parent field that stores a pointer > to the parent struct media_device. But recently a media_gobj was > embedded into the entities and since struct media_gojb already has > a pointer to a struct media_device in the .mdev field, the .parent > field becomes redundant and can be removed. > > This patch replaces all the usage of .parent by .graph_obj.mdev so > that field will become unused and can be removed on a later patch. > > No functional changes. > > The transformation was made using the following coccinelle spatch: > > @@ > struct media_entity *me; > @@ > > - me->parent > + me->graph_obj.mdev > > @@ > struct media_entity *link; > @@ > > - link->source->entity->parent > + link->source->entity->graph_obj.mdev > > @@ > struct exynos_video_entity *ve; > @@ > > - ve->vdev.entity.parent > + ve->vdev.entity.graph_obj.mdev > > Suggested-by: Mauro Carvalho Chehab > Signed-off-by: Javier Martinez Canillas Acked-by: Hans Verkuil Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Date: Thu, 20 Aug 2015 12:43:11 +0000 Subject: Re: [PATCH 3/4] [media] media: use entity.graph_obj.mdev instead of .parent Message-Id: <55D5CB5F.2010106@xs4all.nl> List-Id: References: <1439998526-12832-1-git-send-email-javier@osg.samsung.com> <1439998526-12832-4-git-send-email-javier@osg.samsung.com> In-Reply-To: <1439998526-12832-4-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 08/19/15 17:35, Javier Martinez Canillas wrote: > The struct media_entity has a .parent field that stores a pointer > to the parent struct media_device. But recently a media_gobj was > embedded into the entities and since struct media_gojb already has > a pointer to a struct media_device in the .mdev field, the .parent > field becomes redundant and can be removed. > > This patch replaces all the usage of .parent by .graph_obj.mdev so > that field will become unused and can be removed on a later patch. > > No functional changes. > > The transformation was made using the following coccinelle spatch: > > @@ > struct media_entity *me; > @@ > > - me->parent > + me->graph_obj.mdev > > @@ > struct media_entity *link; > @@ > > - link->source->entity->parent > + link->source->entity->graph_obj.mdev > > @@ > struct exynos_video_entity *ve; > @@ > > - ve->vdev.entity.parent > + ve->vdev.entity.graph_obj.mdev > > Suggested-by: Mauro Carvalho Chehab > Signed-off-by: Javier Martinez Canillas Acked-by: Hans Verkuil Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: hverkuil@xs4all.nl (Hans Verkuil) Date: Thu, 20 Aug 2015 14:43:11 +0200 Subject: [PATCH 3/4] [media] media: use entity.graph_obj.mdev instead of .parent In-Reply-To: <1439998526-12832-4-git-send-email-javier@osg.samsung.com> References: <1439998526-12832-1-git-send-email-javier@osg.samsung.com> <1439998526-12832-4-git-send-email-javier@osg.samsung.com> Message-ID: <55D5CB5F.2010106@xs4all.nl> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/19/15 17:35, Javier Martinez Canillas wrote: > The struct media_entity has a .parent field that stores a pointer > to the parent struct media_device. But recently a media_gobj was > embedded into the entities and since struct media_gojb already has > a pointer to a struct media_device in the .mdev field, the .parent > field becomes redundant and can be removed. > > This patch replaces all the usage of .parent by .graph_obj.mdev so > that field will become unused and can be removed on a later patch. > > No functional changes. > > The transformation was made using the following coccinelle spatch: > > @@ > struct media_entity *me; > @@ > > - me->parent > + me->graph_obj.mdev > > @@ > struct media_entity *link; > @@ > > - link->source->entity->parent > + link->source->entity->graph_obj.mdev > > @@ > struct exynos_video_entity *ve; > @@ > > - ve->vdev.entity.parent > + ve->vdev.entity.graph_obj.mdev > > Suggested-by: Mauro Carvalho Chehab > Signed-off-by: Javier Martinez Canillas Acked-by: Hans Verkuil Regards, Hans