From mboxrd@z Thu Jan 1 00:00:00 1970 From: Helge Deller Subject: Re: A500 boot crash in 4.2.0-rc3-00246-g763e326 Date: Thu, 20 Aug 2015 23:15:06 +0200 Message-ID: <55D6435A.9060808@gmx.de> References: <55D38BE6.6080302@gmx.de> <20150820054234.GA10267@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Cc: John David Anglin , Meelis Roos , linux-parisc@vger.kernel.org, "linux-pci@vger.kernel.org" , "sparclinux@vger.kernel.org" , James Bottomley To: Yinghai Lu , Bjorn Helgaas Return-path: In-Reply-To: List-ID: List-Id: linux-parisc.vger.kernel.org On 20.08.2015 21:31, Yinghai Lu wrote: > On Wed, Aug 19, 2015 at 10:42 PM, Bjorn Helgaas wrote: > >> commit 51a660a2732c >> Author: Bjorn Helgaas >> Date: Thu Aug 20 00:08:15 2015 -0500 >> >> PCI: Don't use 64-bit bus addresses on PA-RISC >> >> Meelis and Helge reported that 3a9ad0b4fdcd ("PCI: Add pci_bus_addr_t") >> caused HPMCs on A500 and hangs on rp5470. >> >> PA-RISC does not set ARCH_DMA_ADDR_T_64BIT, even for 64-bit kernels, so >> prior to 3a9ad0b4fdcd, we always used 32-bit PCI addresses. After >> 3a9ad0b4fdcd, we do use 64-bit PCI addresses in 64-bit kernels, and >> apparently there's some PA-RISC problem related to them. >> >> Fixes: 3a9ad0b4fdcd ("PCI: Add pci_bus_addr_t") >> Link: http://lkml.kernel.org/r/alpine.LRH.2.11.1507260929000.30065@math.ut.ee >> Reported-by: Meelis Roos >> Reported-by: Helge Deller >> Based-on-idea-by: Yinghai Lu >> Signed-off-by: Bjorn Helgaas >> >> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig >> index 73de4ef..944f500 100644 >> --- a/drivers/pci/Kconfig >> +++ b/drivers/pci/Kconfig >> @@ -2,7 +2,7 @@ >> # PCI configuration >> # >> config PCI_BUS_ADDR_T_64BIT >> - def_bool y if (ARCH_DMA_ADDR_T_64BIT || 64BIT) >> + def_bool y if (ARCH_DMA_ADDR_T_64BIT || (64BIT && !PARISC)) >> depends on PCI >> >> config PCI_MSI > > Yes, that is better. > > Acked-by: Yinghai Lu Tested-by: Helge Deller and please add: CC: stable@vger.kernel.org # v3.19+ Helge From mboxrd@z Thu Jan 1 00:00:00 1970 From: Helge Deller Date: Thu, 20 Aug 2015 21:15:06 +0000 Subject: Re: A500 boot crash in 4.2.0-rc3-00246-g763e326 Message-Id: <55D6435A.9060808@gmx.de> List-Id: References: <55D38BE6.6080302@gmx.de> <20150820054234.GA10267@google.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yinghai Lu , Bjorn Helgaas Cc: John David Anglin , Meelis Roos , linux-parisc@vger.kernel.org, "linux-pci@vger.kernel.org" , "sparclinux@vger.kernel.org" , James Bottomley On 20.08.2015 21:31, Yinghai Lu wrote: > On Wed, Aug 19, 2015 at 10:42 PM, Bjorn Helgaas wrote: > >> commit 51a660a2732c >> Author: Bjorn Helgaas >> Date: Thu Aug 20 00:08:15 2015 -0500 >> >> PCI: Don't use 64-bit bus addresses on PA-RISC >> >> Meelis and Helge reported that 3a9ad0b4fdcd ("PCI: Add pci_bus_addr_t") >> caused HPMCs on A500 and hangs on rp5470. >> >> PA-RISC does not set ARCH_DMA_ADDR_T_64BIT, even for 64-bit kernels, so >> prior to 3a9ad0b4fdcd, we always used 32-bit PCI addresses. After >> 3a9ad0b4fdcd, we do use 64-bit PCI addresses in 64-bit kernels, and >> apparently there's some PA-RISC problem related to them. >> >> Fixes: 3a9ad0b4fdcd ("PCI: Add pci_bus_addr_t") >> Link: http://lkml.kernel.org/r/alpine.LRH.2.11.1507260929000.30065@math.ut.ee >> Reported-by: Meelis Roos >> Reported-by: Helge Deller >> Based-on-idea-by: Yinghai Lu >> Signed-off-by: Bjorn Helgaas >> >> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig >> index 73de4ef..944f500 100644 >> --- a/drivers/pci/Kconfig >> +++ b/drivers/pci/Kconfig >> @@ -2,7 +2,7 @@ >> # PCI configuration >> # >> config PCI_BUS_ADDR_T_64BIT >> - def_bool y if (ARCH_DMA_ADDR_T_64BIT || 64BIT) >> + def_bool y if (ARCH_DMA_ADDR_T_64BIT || (64BIT && !PARISC)) >> depends on PCI >> >> config PCI_MSI > > Yes, that is better. > > Acked-by: Yinghai Lu Tested-by: Helge Deller and please add: CC: stable@vger.kernel.org # v3.19+ Helge