From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com. [210.118.77.11]) by gmr-mx.google.com with ESMTPS id fy14si643682pdb.2.2015.08.20.17.44.58 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 20 Aug 2015 17:44:58 -0700 (PDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NTE006ZVQ2TM610@mailout1.w1.samsung.com> for rtc-linux@googlegroups.com; Fri, 21 Aug 2015 01:44:53 +0100 (BST) Message-id: <55D67487.3040503@samsung.com> Date: Fri, 21 Aug 2015 09:44:55 +0900 From: Krzysztof Kozlowski MIME-version: 1.0 To: Alexandre Belloni , Joonyoung Shim Cc: rtc-linux@googlegroups.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, a.zummo@towertech.it, sbkim73@samsung.com Subject: [rtc-linux] Re: [PATCH] rtc: s5m: fix to update ctrl register References: <1439455764-23526-1-git-send-email-jy0922.shim@samsung.com> <20150820231551.GE3769@piout.net> In-reply-to: <20150820231551.GE3769@piout.net> Content-type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 21.08.2015 08:15, Alexandre Belloni wrote: > Hi, > > On 13/08/2015 at 17:49:24 +0900, Joonyoung Shim wrote : >> According to datasheet, the S2MPS13X and S2MPS14X should update write >> buffer via setting WUDR bit to high after ctrl register is updated. >> >> If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use >> tools/testing/selftests/timers/rtctest.c test program and hour format is >> used to 12 hour mode in Odroid-XU3 board. >> > >>>From what I understood, I should expect a v2 of tihat patch also setting > RUDR, is that right? OR would you prefer that I apply that one and then > fix RUDR in a following patch? Right, I would expect that as well... or a comment if this is not needed. Best regards, Krzysztof > >> Signed-off-by: Joonyoung Shim >> Cc: > > can you update the stable tag with the kernel version introducing the > issue? > >> --- >> drivers/rtc/rtc-s5m.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > >> diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c >> index 8c70d78..03828bb 100644 >> --- a/drivers/rtc/rtc-s5m.c >> +++ b/drivers/rtc/rtc-s5m.c >> @@ -635,6 +635,18 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) >> case S2MPS13X: >> data[0] = (0 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); >> ret = regmap_write(info->regmap, info->regs->ctrl, data[0]); >> + if (ret < 0) >> + break; >> + >> + ret = regmap_update_bits(info->regmap, >> + info->regs->rtc_udr_update, >> + info->regs->rtc_udr_mask, >> + info->regs->rtc_udr_mask); > > Very small indentation issue here, it should be aligned with the open > parenthesis. > > -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] rtc: s5m: fix to update ctrl register Date: Fri, 21 Aug 2015 09:44:55 +0900 Message-ID: <55D67487.3040503@samsung.com> References: <1439455764-23526-1-git-send-email-jy0922.shim@samsung.com> <20150820231551.GE3769@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20150820231551.GE3769@piout.net> Sender: stable-owner@vger.kernel.org To: Alexandre Belloni , Joonyoung Shim Cc: rtc-linux@googlegroups.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, a.zummo@towertech.it, sbkim73@samsung.com List-Id: linux-samsung-soc@vger.kernel.org On 21.08.2015 08:15, Alexandre Belloni wrote: > Hi, > > On 13/08/2015 at 17:49:24 +0900, Joonyoung Shim wrote : >> According to datasheet, the S2MPS13X and S2MPS14X should update write >> buffer via setting WUDR bit to high after ctrl register is updated. >> >> If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use >> tools/testing/selftests/timers/rtctest.c test program and hour format is >> used to 12 hour mode in Odroid-XU3 board. >> > >>>From what I understood, I should expect a v2 of tihat patch also setting > RUDR, is that right? OR would you prefer that I apply that one and then > fix RUDR in a following patch? Right, I would expect that as well... or a comment if this is not needed. Best regards, Krzysztof > >> Signed-off-by: Joonyoung Shim >> Cc: > > can you update the stable tag with the kernel version introducing the > issue? > >> --- >> drivers/rtc/rtc-s5m.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > >> diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c >> index 8c70d78..03828bb 100644 >> --- a/drivers/rtc/rtc-s5m.c >> +++ b/drivers/rtc/rtc-s5m.c >> @@ -635,6 +635,18 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) >> case S2MPS13X: >> data[0] = (0 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); >> ret = regmap_write(info->regmap, info->regs->ctrl, data[0]); >> + if (ret < 0) >> + break; >> + >> + ret = regmap_update_bits(info->regmap, >> + info->regs->rtc_udr_update, >> + info->regs->rtc_udr_mask, >> + info->regs->rtc_udr_mask); > > Very small indentation issue here, it should be aligned with the open > parenthesis. > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:46652 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbbHUAo4 (ORCPT ); Thu, 20 Aug 2015 20:44:56 -0400 Message-id: <55D67487.3040503@samsung.com> Date: Fri, 21 Aug 2015 09:44:55 +0900 From: Krzysztof Kozlowski MIME-version: 1.0 To: Alexandre Belloni , Joonyoung Shim Cc: rtc-linux@googlegroups.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, a.zummo@towertech.it, sbkim73@samsung.com Subject: Re: [PATCH] rtc: s5m: fix to update ctrl register References: <1439455764-23526-1-git-send-email-jy0922.shim@samsung.com> <20150820231551.GE3769@piout.net> In-reply-to: <20150820231551.GE3769@piout.net> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 21.08.2015 08:15, Alexandre Belloni wrote: > Hi, > > On 13/08/2015 at 17:49:24 +0900, Joonyoung Shim wrote : >> According to datasheet, the S2MPS13X and S2MPS14X should update write >> buffer via setting WUDR bit to high after ctrl register is updated. >> >> If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use >> tools/testing/selftests/timers/rtctest.c test program and hour format is >> used to 12 hour mode in Odroid-XU3 board. >> > >>>>From what I understood, I should expect a v2 of tihat patch also setting > RUDR, is that right? OR would you prefer that I apply that one and then > fix RUDR in a following patch? Right, I would expect that as well... or a comment if this is not needed. Best regards, Krzysztof > >> Signed-off-by: Joonyoung Shim >> Cc: > > can you update the stable tag with the kernel version introducing the > issue? > >> --- >> drivers/rtc/rtc-s5m.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > >> diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c >> index 8c70d78..03828bb 100644 >> --- a/drivers/rtc/rtc-s5m.c >> +++ b/drivers/rtc/rtc-s5m.c >> @@ -635,6 +635,18 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) >> case S2MPS13X: >> data[0] = (0 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); >> ret = regmap_write(info->regmap, info->regs->ctrl, data[0]); >> + if (ret < 0) >> + break; >> + >> + ret = regmap_update_bits(info->regmap, >> + info->regs->rtc_udr_update, >> + info->regs->rtc_udr_mask, >> + info->regs->rtc_udr_mask); > > Very small indentation issue here, it should be aligned with the open > parenthesis. > >