From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSeg6-0005ga-RT for qemu-devel@nongnu.org; Fri, 21 Aug 2015 01:15:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZSeg1-0005lX-Rs for qemu-devel@nongnu.org; Fri, 21 Aug 2015 01:15:46 -0400 Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]:35086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSeg1-0005lN-KW for qemu-devel@nongnu.org; Fri, 21 Aug 2015 01:15:41 -0400 Received: by pacdd16 with SMTP id dd16so35855200pac.2 for ; Thu, 20 Aug 2015 22:15:40 -0700 (PDT) Sender: Richard Henderson References: From: Richard Henderson Message-ID: <55D6B3F9.8030109@twiddle.net> Date: Thu, 20 Aug 2015 22:15:37 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/16 v1] tilegx: Firstly add tilegx target for linux-user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Gang , Peter Maydell , Chris Metcalf , =?UTF-8?Q?Andreas_F=c3=a4rber?= , "walt@tilera.com" , Riku Voipio Cc: qemu-devel First off, this isn't v1. The previous patch set you posted was v12. On 08/20/2015 02:32 PM, Chen Gang wrote: > Chen Gang (16): > linux-user: tilegx: Firstly add architecture related features > linux-user: Support tilegx architecture in linux-user > linux-user/syscall.c: conditionalize syscalls which are not defined in > tilegx > target-tilegx: Add opcode basic implementation from Tilera Corporation > target-tilegx/opcode_tilegx.h: Modify it to fit QEMU usage > target-tilegx: Add special register information from Tilera > Corporation > target-tilegx: Add cpu basic features for linux-user > target-tilegx: Add several helpers for instructions translation > target-tilegx: Generate tcg instructions to finish "Hello world" This patch is too big. Way way too big. We've discussed this before, and you changed the v9 patch set in the correct direction (though it wasn't split far enough). But then you merged them all back together in v10. That's just unacceptable. > target-tilegx: Add TILE-Gx building files > target-tilegx: Add related feature to support iret instruction > target-tilegx: Implement decode_rrr_8_opcode_y0 > target-tilegx: Use int8_t instead of uint8_t for imm8 in gen_st_add() > linux-user: main: Use negative qemu errno for syscall return errno > tilegx: Match with the latest qemu master tree These three patches are fixes for previous patches should have been merged back into the respective original patches. > target-tilegx: Implement additional instructions in normal working > flow This patch is also too big. In addition, I believe there's a better way to organize the decoding. I mentioned this before in one of the review cycles, but this was not followed up from either your side or mine. I've spent the evening flushing out the idea and will follow up with a patch set. r~