All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Hellstrom <thellstrom@vmware.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>,
	ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/7] drm/vmwgfx: Initial DX support
Date: Fri, 21 Aug 2015 14:27:38 +0200	[thread overview]
Message-ID: <55D7193A.9010405@vmware.com> (raw)
In-Reply-To: <CACvgo52JXtr0OjtSh62LA+qqdA79cP-LPL=FeJjgOi7aqKs=-A@mail.gmail.com>

On 08/21/2015 02:19 PM, Emil Velikov wrote:
> Hi Thomas,
>
> On 13 August 2015 at 06:49, Thomas Hellstrom <thellstrom@vmware.com> wrote:
> [snip]
>> --- a/include/uapi/drm/vmwgfx_drm.h
>> +++ b/include/uapi/drm/vmwgfx_drm.h
>> @@ -826,7 +830,6 @@ struct drm_vmw_update_layout_arg {
>>  enum drm_vmw_shader_type {
>>         drm_vmw_shader_type_vs = 0,
>>         drm_vmw_shader_type_ps,
>> -       drm_vmw_shader_type_gs
>>  };
>>
> Won't this hunk cause API/ABI breakage ? I guess one could get away if
> no users ever relied upon it.

Hi, Emil,

You're right. However, the kernel driver (other than in-house
development versions) should never have supported the gs shader type
anyway, so we don't break anything existing. With the current version,
geometry shaders are created using the GPU command stream.

Thanks,
Thomas



>
> Thanks
> Emil
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-08-21 12:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13  5:49 [PATCH 0/7] vmwgfx GL3 support Thomas Hellstrom
2015-08-13  5:49 ` [PATCH 1/7] drm: export the DRM permission check code Thomas Hellstrom
2015-08-13  5:49 ` [PATCH 2/7] drm/vmwgfx: Update device includes for DX device functionality Thomas Hellstrom
2015-08-13  5:49 ` [PATCH 3/7] drm/vmwgfx: Initial DX support Thomas Hellstrom
2015-08-21 12:19   ` Emil Velikov
2015-08-21 12:27     ` Thomas Hellstrom [this message]
2015-08-13  5:49 ` [PATCH 4/7] drm/vmwgfx: Command parser fixes for DX Thomas Hellstrom
2015-08-13  5:49 ` [PATCH 5/7] drm/vmwgfx: Add command parser support for a couple of DX commands Thomas Hellstrom
2015-08-13  5:49 ` [PATCH 6/7] drm/vmwgfx: Add DX query support. Various fixes Thomas Hellstrom
2015-08-13  5:49 ` [PATCH 7/7] drm/vmwgfx: Fix copyright headers Thomas Hellstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D7193A.9010405@vmware.com \
    --to=thellstrom@vmware.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.