From: Andreas Ruprecht <andreas.ruprecht@fau.de>
To: Jianwei Wang <jianwei.wang.chn@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Xiubo Li <lixiubo@cmss.chinamobile.com>,
Alison Wang <b18965@freescale.com>,
Valentin Rothberg <valentinrothberg@gmail.com>,
Stefan Hengelein <stefan.hengelein@fau.de>
Subject: Re: drm/layerscape: Add Freescale DCU DRM driver
Date: Fri, 21 Aug 2015 15:41:16 +0200 [thread overview]
Message-ID: <55D72A7C.1020101@fau.de> (raw)
Hi Jianwei,
your commit 109eee2f2a18 ("drm/layerscape: Add Freescale DCU DRM
driver") showed up in linux-next today (i.e., next-20150821). I noticed
it because we are running a daily analysis on the newest linux-next tree
as part of our research.
In the source code of fsl_dcu_drm_drv.c, there is the following #ifdef:
#ifdef CONFIG_COMPAT
.compat_ioctl = drm_compat_ioctl,
#endif
The Kconfig option for the driver, however, states that the driver can
only be built with CONFIG_ARM enabled:
config DRM_FSL_DCU
tristate "DRM Support for Freescale DCU"
depends on DRM && OF && ARM
[...]
Inside arch/arm/, however, there is no definition of CONFIG_COMPAT (note
that there is one in arch/arm64/, but the driver explicitely needs
CONFIG_ARM), so the #ifdef block above can never be compiled in the
current state. Is this intended?
Regards,
Andreas
next reply other threads:[~2015-08-21 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 13:41 Andreas Ruprecht [this message]
2015-08-24 4:04 ` drm/layerscape: Add Freescale DCU DRM driver Jianwei Wang
2015-08-24 4:10 ` Jianwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D72A7C.1020101@fau.de \
--to=andreas.ruprecht@fau.de \
--cc=b18965@freescale.com \
--cc=daniel.vetter@ffwll.ch \
--cc=jianwei.wang.chn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lixiubo@cmss.chinamobile.com \
--cc=stefan.hengelein@fau.de \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.