From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSzn0-0005PI-SP for qemu-devel@nongnu.org; Fri, 21 Aug 2015 23:48:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZSzmw-0005VQ-MU for qemu-devel@nongnu.org; Fri, 21 Aug 2015 23:48:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSzmw-0005VH-H8 for qemu-devel@nongnu.org; Fri, 21 Aug 2015 23:48:14 -0400 References: <1440029085-14539-1-git-send-email-eblake@redhat.com> <1440029085-14539-6-git-send-email-eblake@redhat.com> From: Eric Blake Message-ID: <55D7F0F5.3020503@redhat.com> Date: Fri, 21 Aug 2015 20:48:05 -0700 MIME-Version: 1.0 In-Reply-To: <1440029085-14539-6-git-send-email-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cAXTV85W5EFJGsAaIKLGEW98raPBRCdug" Subject: Re: [Qemu-devel] [PATCH RFC 5/5] qapi: Allow anonymous base for flat union List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cAXTV85W5EFJGsAaIKLGEW98raPBRCdug Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/19/2015 05:04 PM, Eric Blake wrote: > Rather than requiring all flat unions to explicitly create > a separate base struct, we want to allow the qapi schema > to specify the common fields via an inline dictionary. This > is similar to how commands can specify inline types for the > arguments. >=20 > Now that the feature is legal, we can drop the former > flat-union-bad-base negative test, and instead change the > positive tests in qapi-schema-test to use it. >=20 > Signed-off-by: Eric Blake > --- > scripts/qapi-commands.py | 2 +- > scripts/qapi-types.py | 2 +- > scripts/qapi-visit.py | 13 +++++++--- > scripts/qapi.py | 39 ++++++++++++++++++----= -------- > tests/Makefile | 3 +-- > tests/qapi-schema/flat-union-bad-base.err | 1 - > tests/qapi-schema/flat-union-bad-base.exit | 1 - > tests/qapi-schema/flat-union-bad-base.json | 13 ---------- > tests/qapi-schema/flat-union-bad-base.out | 0 > tests/qapi-schema/qapi-schema-test.json | 2 +- > tests/qapi-schema/qapi-schema-test.out | 5 +++- > 11 files changed, 41 insertions(+), 40 deletions(-) Of course, I forgot to include changes to docs/qapi-code-gen.txt. They will be present in the next (non-RFC) version. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cAXTV85W5EFJGsAaIKLGEW98raPBRCdug Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV1/D1AAoJEKeha0olJ0NqnR4IALB+KbdVEQjHtRRZK/gGruF+ 6sFucnGQTsaiUdibFlAK7Rs6zOplVOWQezSEfRA8/KJ+BNdnA4AqhvtwW71JmoaJ m3Tmrdw4xLQqv63Rb+9/V/EbC35L2F2cMGcJJTSxrDxU4IhVIbm+aRIOf7xlUlpG dIXjCLyWKsrG+uc0/WLoyrKxWh0QWu2zc5UWj6E4ddB+nULuwuOEbPde6zZKXLJm zSTSdEXCd6Bx6+tD7CO1Z5Ztxc6au7GVxVJxbzb7Gt7lCL1hd8usvDbKYYv9Auym HC/59FIJTk0KyARaOSq2/ZwZx0E+DJBnwZtw7rFgm2zP9wSzQNLEqPvlrQF4mAs= =It83 -----END PGP SIGNATURE----- --cAXTV85W5EFJGsAaIKLGEW98raPBRCdug--