From: "H. Peter Anvin" <hpa@zytor.com>
To: linux-kernel@vger.kernel.org, luto@amacapital.net,
peterz@infradead.org, w@1wt.eu, mingo@kernel.org,
torvalds@linux-foundation.org, tglx@linutronix.de, bp@alien8.de,
dvlasenk@redhat.com, brgerst@gmail.com, luto@kernel.org,
rostedt@goodmis.org, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/asm] x86/asm/msr: Make wrmsrl() a function
Date: Sun, 23 Aug 2015 12:23:58 -0700 [thread overview]
Message-ID: <55DA1DCE.60401@zytor.com> (raw)
In-Reply-To: <tip-47edb65178cb7056c2eea0b6c41a7d8c84547192@git.kernel.org>
On 08/23/2015 04:45 AM, tip-bot for Andy Lutomirski wrote:
> Commit-ID: 47edb65178cb7056c2eea0b6c41a7d8c84547192
> Gitweb: http://git.kernel.org/tip/47edb65178cb7056c2eea0b6c41a7d8c84547192
> Author: Andy Lutomirski <luto@kernel.org>
> AuthorDate: Thu, 23 Jul 2015 12:14:40 -0700
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Sun, 23 Aug 2015 13:25:38 +0200
>
> x86/asm/msr: Make wrmsrl() a function
>
> As of cf991de2f614 ("x86/asm/msr: Make wrmsrl_safe() a
> function"), wrmsrl_safe is a function, but wrmsrl is still a
> macro. The wrmsrl macro performs invalid shifts if the value
> argument is 32 bits. This makes it unnecessarily awkward to
> write code that puts an unsigned long into an MSR.
>
Looking at this: where do you see an invalid shift? Everywhere I can
see we do the proper casting. Still not side effect free, though.
-hpa
next prev parent reply other threads:[~2015-08-23 19:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 19:14 [PATCH v2] x86/asm/msr: Make wrmsrl() a function Andy Lutomirski
2015-07-23 19:14 ` [PATCH v2] x86/entry/32: Remove duplicate initialization of tss.ss1 Andy Lutomirski
2015-08-23 11:26 ` Ingo Molnar
2015-08-23 15:43 ` Andy Lutomirski
2015-08-24 6:48 ` Ingo Molnar
2015-08-23 11:45 ` [tip:x86/asm] x86/asm/msr: Make wrmsrl() a function tip-bot for Andy Lutomirski
2015-08-23 19:23 ` H. Peter Anvin [this message]
2015-08-24 18:11 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DA1DCE.60401@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.