All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Platte <lists@naasa.net>
To: alexander.deucher@amd.com, linux-kernel@vger.kernel.org
Subject: drm/radeon: take the mode_config mutex when dealing with hpds (v2) crashes
Date: Mon, 24 Aug 2015 05:25:43 +0200	[thread overview]
Message-ID: <55DA8EB7.9000206@naasa.net> (raw)

Dear Alex,

on my old P4 based non-SMP router your patch (commit 
32d12fc20e3c726ca858d0e5055fb596fce2f8bc in linux stable) crashes on 
Linux 4.1.4 and above. I was only able to take a picture of the whole 
trace https://ferdi.naasa.net/url/jplatte/IMG_3116.JPG

Reverting the patch resolves the issue.

This is my old graphics hardware:
01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. 
[AMD/ATI] RV100 [Radeon 7000 / Radeon VE]

Just for the reference, here is the full patch:
commit 32d12fc20e3c726ca858d0e5055fb596fce2f8bc
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Fri May 15 11:48:52 2015 -0400

     drm/radeon: take the mode_config mutex when dealing with hpds (v2)

     commit 39fa10f7e21574a70cecf1fed0f9b36535aa68a0 upstream.

     Since we are messing with state in the worker.

     v2: drop the changes in the mst worker

     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/gpu/drm/radeon/radeon_irq_kms.c 
b/drivers/gpu/drm/radeon/radeon_irq_kms.c
index 7162c93..f682e53 100644
--- a/drivers/gpu/drm/radeon/radeon_irq_kms.c
+++ b/drivers/gpu/drm/radeon/radeon_irq_kms.c
@@ -79,10 +79,12 @@ static void radeon_hotplug_work_func(struct 
work_struct *work)
         struct drm_mode_config *mode_config = &dev->mode_config;
         struct drm_connector *connector;

+       mutex_lock(&mode_config->mutex);
         if (mode_config->num_connector) {
                 list_for_each_entry(connector, 
&mode_config->connector_list, head)
                         radeon_connector_hotplug(connector);
         }
+       mutex_unlock(&mode_config->mutex);
         /* Just fire off a uevent and let userspace tell us what to do */
         drm_helper_hpd_irq_event(dev);
  }

Is it possible that the mutex is not defined on non-SMP systems? Can you 
help to resolve this regression?

Best regards,
Joerg

             reply	other threads:[~2015-08-24  3:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24  3:25 Joerg Platte [this message]
2015-08-25 17:10 ` drm/radeon: take the mode_config mutex when dealing with hpds (v2) crashes Deucher, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DA8EB7.9000206@naasa.net \
    --to=lists@naasa.net \
    --cc=alexander.deucher@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.