From: Bernhard Nortmann <bernhard.nortmann@web.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 1/3] expose eth_is_active() function to test network device state
Date: Mon, 24 Aug 2015 12:20:14 +0200 [thread overview]
Message-ID: <55DAEFDE.5040809@web.de> (raw)
In-Reply-To: <CAPnjgZ3aNm8tRJd+ohFhoGC8j-eVoRhXCj7V=KDu-N9bXFDrMQ@mail.gmail.com>
Hi Simon!
Am 23.08.2015 23:21, schrieb Simon Glass:
> A few points:
>
> - You should tag your patch with the subsystem it targets - in your
> case I think you should prefix the subject with 'net: '
Okay. I'll keep that in mind for future reiterations of this patch set.
Btw: Thanks for looking into my stuff.
> - Do you have a patch to enable netconsole on an existing board? If
> the code you add is never built then it could break at any moment
netconsole seems to receive little love actually :D (It's been broken /
would
cause compilation errors with CONFIG_DM_ETH for quite some time now,
since commit b6006baf9c2553543e3384983d23d95efbf24fa6 in April.)
So I'm not sure I get your question. As mentioned in the cover letter I've
been testing this code with and without CONFIG_DM_ETH for my Banana Pi,
i.e. sunxi GMAC (by simply adding #define CONFIG_NETCONSOLE).
Regards, B. Nortmann
> Regards,
> Simon
next prev parent reply other threads:[~2015-08-24 10:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 22:30 [U-Boot] [RFC PATCH 0/3] fix netconsole for CONFIG_DM_ETH Bernhard Nortmann
2015-08-21 22:30 ` [U-Boot] [RFC PATCH 1/3] expose eth_is_active() function to test network device state Bernhard Nortmann
2015-08-23 21:21 ` Simon Glass
2015-08-24 10:20 ` Bernhard Nortmann [this message]
2015-08-24 16:59 ` Simon Glass
2015-08-24 17:02 ` Joe Hershberger
2015-08-25 9:53 ` Bernhard Nortmann
2015-08-25 15:55 ` Joe Hershberger
2015-08-25 18:01 ` Bernhard Nortmann
2015-08-25 18:13 ` Joe Hershberger
2015-08-21 22:30 ` [U-Boot] [RFC PATCH 2/3] fix netconsole when CONFIG_DM_ETH is set Bernhard Nortmann
2015-08-21 22:30 ` [U-Boot] [RFC PATCH 3/3] avoid eth_unregister() call when function is unavailable Bernhard Nortmann
2015-08-23 21:21 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DAEFDE.5040809@web.de \
--to=bernhard.nortmann@web.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.