From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qais Yousef Subject: Re: [PATCH 01/10] irqchip: irq-mips-gic: export gic_send_ipi Date: Mon, 24 Aug 2015 14:02:35 +0100 Message-ID: <55DB15EB.3090109@imgtec.com> References: <1440419959-14315-1-git-send-email-qais.yousef@imgtec.com> <1440419959-14315-2-git-send-email-qais.yousef@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by alsa0.perex.cz (Postfix) with ESMTP id E1EB32606FC for ; Mon, 24 Aug 2015 15:02:36 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Thomas Gleixner Cc: Marc Zyngier , linux-mips@linux-mips.org, alsa-devel@alsa-project.org, Jason Cooper , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On 08/24/2015 01:49 PM, Thomas Gleixner wrote: > On Mon, 24 Aug 2015, Qais Yousef wrote: > >> Some drivers might require to send ipi to other cores. So export it. > Which IPIs do you need to send from a driver which are not exposed by > the SMP functions already? It's not an SMP IPI. We use GIC to exchange interrupts between AXD and the host system since AXD is another MIPS core in the cluster. >> This will be used later by AXD driver. > That smells fishy and it wants a proper explanation WHY and not just a > sloppy statement that it will be used later. I can figure that out > myself as exporting a function without using it does not make any sense. Sorry for the terse explanation. As pointed above AXD uses GIC to send and receive interrupts to the host core. Without this change I can't compile the driver as a driver module because the symbol is not exported. Does this make things clearer? Thanks, Qais > > Thanks, > > tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 24 Aug 2015 15:02:50 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:8305 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27011154AbbHXNCmFiUOr (ORCPT ); Mon, 24 Aug 2015 15:02:42 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id CE90210AC765C; Mon, 24 Aug 2015 14:02:33 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 24 Aug 2015 14:02:36 +0100 Received: from [192.168.154.94] (192.168.154.94) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.210.2; Mon, 24 Aug 2015 14:02:35 +0100 Message-ID: <55DB15EB.3090109@imgtec.com> Date: Mon, 24 Aug 2015 14:02:35 +0100 From: Qais Yousef User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Thomas Gleixner CC: , Jason Cooper , "Marc Zyngier" , , Subject: Re: [PATCH 01/10] irqchip: irq-mips-gic: export gic_send_ipi References: <1440419959-14315-1-git-send-email-qais.yousef@imgtec.com> <1440419959-14315-2-git-send-email-qais.yousef@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.94] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 49001 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: qais.yousef@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 08/24/2015 01:49 PM, Thomas Gleixner wrote: > On Mon, 24 Aug 2015, Qais Yousef wrote: > >> Some drivers might require to send ipi to other cores. So export it. > Which IPIs do you need to send from a driver which are not exposed by > the SMP functions already? It's not an SMP IPI. We use GIC to exchange interrupts between AXD and the host system since AXD is another MIPS core in the cluster. >> This will be used later by AXD driver. > That smells fishy and it wants a proper explanation WHY and not just a > sloppy statement that it will be used later. I can figure that out > myself as exporting a function without using it does not make any sense. Sorry for the terse explanation. As pointed above AXD uses GIC to send and receive interrupts to the host core. Without this change I can't compile the driver as a driver module because the symbol is not exported. Does this make things clearer? Thanks, Qais > > Thanks, > > tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:8305 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27011154AbbHXNCmFiUOr (ORCPT ); Mon, 24 Aug 2015 15:02:42 +0200 Message-ID: <55DB15EB.3090109@imgtec.com> Date: Mon, 24 Aug 2015 14:02:35 +0100 From: Qais Yousef MIME-Version: 1.0 Subject: Re: [PATCH 01/10] irqchip: irq-mips-gic: export gic_send_ipi References: <1440419959-14315-1-git-send-email-qais.yousef@imgtec.com> <1440419959-14315-2-git-send-email-qais.yousef@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Thomas Gleixner Cc: alsa-devel@alsa-project.org, Jason Cooper , Marc Zyngier , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Message-ID: <20150824130235.UxDbsMPoyMp5WKvkLXOeW1fPi2G74zHA9ohZnW-s0Ms@z> On 08/24/2015 01:49 PM, Thomas Gleixner wrote: > On Mon, 24 Aug 2015, Qais Yousef wrote: > >> Some drivers might require to send ipi to other cores. So export it. > Which IPIs do you need to send from a driver which are not exposed by > the SMP functions already? It's not an SMP IPI. We use GIC to exchange interrupts between AXD and the host system since AXD is another MIPS core in the cluster. >> This will be used later by AXD driver. > That smells fishy and it wants a proper explanation WHY and not just a > sloppy statement that it will be used later. I can figure that out > myself as exporting a function without using it does not make any sense. Sorry for the terse explanation. As pointed above AXD uses GIC to send and receive interrupts to the host core. Without this change I can't compile the driver as a driver module because the symbol is not exported. Does this make things clearer? Thanks, Qais > > Thanks, > > tglx