From: Steve Dickson <SteveD@redhat.com>
To: andros@netapp.com
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] rpc.gssd: Replace exit(0) by return in process_krb5_upcall
Date: Mon, 24 Aug 2015 13:51:30 -0400 [thread overview]
Message-ID: <55DB59A2.6060209@RedHat.com> (raw)
In-Reply-To: <1440014300-1502-1-git-send-email-andros@netapp.com>
On 08/19/2015 03:58 PM, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
>
> exit(0) silenty reaps the gssd_k5_kt_princ struct, the in-memory
> rpc.gssd cache which means that rpc.gssd will get a new TGT and TGS for
> each upcall, ignoring a valid TGT in the kerberos credential cache.
>
> Signed-off-by: Andy Adamson <andros@netapp.com>
Committed...
steved.
> ---
> utils/gssd/gssd_proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
> index 03afc8b..3fc7bba 100644
> --- a/utils/gssd/gssd_proc.c
> +++ b/utils/gssd/gssd_proc.c
> @@ -684,7 +684,7 @@ out:
> AUTH_DESTROY(auth);
> if (rpc_clnt)
> clnt_destroy(rpc_clnt);
> - exit(0);
> + return;
>
> out_return_error:
> do_error_downcall(fd, uid, downcall_err);
>
next prev parent reply other threads:[~2015-08-24 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 19:58 [PATCH] rpc.gssd: Replace exit(0) by return in process_krb5_upcall andros
2015-08-24 17:51 ` Steve Dickson [this message]
2015-09-08 15:16 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DB59A2.6060209@RedHat.com \
--to=steved@redhat.com \
--cc=andros@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.