From: Daniel Borkmann <daniel@iogearbox.net>
To: Marcelo Ricardo Leitner <mleitner@redhat.com>,
Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>, davem@davemloft.net
Subject: Re: [PATCH net] sctp: partial chunk should be drop without sending abort packet
Date: Mon, 24 Aug 2015 20:22:03 +0200 [thread overview]
Message-ID: <55DB60CB.8030002@iogearbox.net> (raw)
In-Reply-To: <20150824124713.GZ1097@localhost.localdomain>
On 08/24/2015 02:47 PM, Marcelo Ricardo Leitner wrote:
> On Mon, Aug 24, 2015 at 06:08:30PM +0800, Xin Long wrote:
>> as RFC 4960, 6.10 said, *if the receiver detects a partial chunk, it MUST drop
>> the chunk*, we should not send the abort. but if we put this discard to inside
>> state machine, it will send abort.
>>
>> so we just drop the partial chunk there, never let this chunk go into the state
>> machine.
>>
>> Signed-off-by: Xin Long <lucien.xin@gmail.com>
>> ---
>
> This is basically reverting a chunk of Daniel's and Vlad's 26b87c788100
> ("net: sctp: fix remote memory pressure from excessive queueing") .
> Isn't it going to re-introduce the initial issue then?
Yes, seems so.
next prev parent reply other threads:[~2015-08-24 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 10:08 [PATCH net] sctp: partial chunk should be drop without sending abort packet Xin Long
2015-08-24 12:47 ` Marcelo Ricardo Leitner
2015-08-24 18:22 ` Daniel Borkmann [this message]
2015-08-24 18:01 ` Vlad Yasevich
2015-08-27 13:41 ` lucien xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DB60CB.8030002@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.