All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com
Subject: Re: [Qemu-devel] [PATCHv2] block/nfs: cache allocated filesize for read-only files
Date: Mon, 24 Aug 2015 20:39:08 +0200	[thread overview]
Message-ID: <55DB64CC.2040207@redhat.com> (raw)
In-Reply-To: <1440403565-27432-1-git-send-email-pl@kamp.de>

On 24.08.2015 10:06, Peter Lieven wrote:
> If the file is readonly its not expected to grow so
> save the blocking call to nfs_fstat_async and use
> the value saved at connection time. Also important
> the monitor (and thus the main loop) will not hang
> if block device info is queried and the NFS share
> is unresponsive.
> 
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> v1->v2: update cache on reopen_prepare [Max]
> 
>  block/nfs.c | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)

Reviewed-by: Max Reitz <mreitz@redhat.com>

I hope you're ready for the "Stale actual-size value with
cache=direct,read-only=on,format=raw files on NFS" reports. :-)

  reply	other threads:[~2015-08-24 18:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24  8:06 [Qemu-devel] [PATCHv2] block/nfs: cache allocated filesize for read-only files Peter Lieven
2015-08-24 18:39 ` Max Reitz [this message]
2015-08-24 19:34   ` Peter Lieven
2015-08-24 20:13     ` Max Reitz
2015-08-26 15:31       ` Jeff Cody
2015-08-26 18:49         ` Peter Lieven
2015-08-26 19:14           ` Jeff Cody
2015-09-03 17:05             ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DB64CC.2040207@redhat.com \
    --to=mreitz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.