From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZU36f-0000WI-AC for qemu-devel@nongnu.org; Mon, 24 Aug 2015 21:32:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZU36b-0005XM-A5 for qemu-devel@nongnu.org; Mon, 24 Aug 2015 21:32:57 -0400 Received: from [59.151.112.132] (port=45793 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZU36b-0005X1-0H for qemu-devel@nongnu.org; Mon, 24 Aug 2015 21:32:53 -0400 Message-ID: <55DBC5B6.2050901@cn.fujitsu.com> Date: Tue, 25 Aug 2015 09:32:38 +0800 From: Yang Hongyang MIME-Version: 1.0 References: <1440132205-7814-1-git-send-email-yanghy@cn.fujitsu.com> <1440132205-7814-11-git-send-email-yanghy@cn.fujitsu.com> <55DA2C04.6000404@redhat.com> In-Reply-To: <55DA2C04.6000404@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 RESEND 10/11] filter/buffer: update command description and help List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com, jasowang@redhat.com, Markus Armbruster , mrhines@linux.vnet.ibm.com, Luiz Capitulino , stefanha@redhat.com On 08/24/2015 04:24 AM, Thomas Huth wrote: > On 21/08/15 00:43, Yang Hongyang wrote: >> now that we have a buffer netfilter, update the command >> description and help. >> >> Signed-off-by: Yang Hongyang >> CC: Luiz Capitulino >> CC: Markus Armbruster >> --- >> hmp-commands.hx | 2 +- >> qemu-options.hx | 5 ++++- >> qmp-commands.hx | 2 +- >> 3 files changed, 6 insertions(+), 3 deletions(-) > ... >> diff --git a/qemu-options.hx b/qemu-options.hx >> index 0d52d02..eeaf2a1 100644 >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -1575,7 +1575,10 @@ DEF("net", HAS_ARG, QEMU_OPTION_net, >> "socket][,vlan=n][,option][,option][,...]\n" >> " old way to initialize a host network interface\n" >> " (use the -netdev option if possible instead)\n", QEMU_ARCH_ALL) >> -DEF("netfilter", HAS_ARG, QEMU_OPTION_netfilter, "", QEMU_ARCH_ALL) >> +DEF("netfilter", HAS_ARG, QEMU_OPTION_netfilter, >> + "-netfilter buffer,id=str,netdev=str[,chain=in|out|all,interval=n]\n" >> + " buffer netdev in/out packets. if interval provided, will release\n" >> + " packets by interval. interval scale: microsecond\n", QEMU_ARCH_ALL) >> STEXI >> @item -net nic[,vlan=@var{n}][,macaddr=@var{mac}][,model=@var{type}] [,name=@var{name}][,addr=@var{addr}][,vectors=@var{v}] >> @findex -net > > Could you maybe also add some more explicit description for the filter > to the TEXI section (i.e. between the above STEXI and the ETEXI later in > this file)? That could be really helpful for the users when they look > for information about this option in the User's Documentation (see > http://qemu.weilnetz.de/qemu-doc.html for a generated version for example) Ok, thanks. > > Thomas > > . > -- Thanks, Yang.