All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] memory-hotplug: fix comment in zone_spanned_pages_in_node() and zone_spanned_pages_in_node()
@ 2015-08-25  2:03 ` Xishi Qiu
  0 siblings, 0 replies; 4+ messages in thread
From: Xishi Qiu @ 2015-08-25  2:03 UTC (permalink / raw)
  To: Tang Chen, Yasuaki Ishimatsu, Andrew Morton, Naoya Horiguchi,
	Vlastimil Babka, mgorman, David Rientjes, Kamezawa Hiroyuki,
	izumi.taku
  Cc: LKML, Linux MM

When hotadd a node from add_memory(), we will add memblock first, so the
node is not empty. But when from cpu_up(), the node should be empty.

Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
---
 mm/page_alloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2ec3ca3..d370445 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5051,7 +5051,7 @@ static unsigned long __meminit zone_spanned_pages_in_node(int nid,
 {
 	unsigned long zone_start_pfn, zone_end_pfn;
 
-	/* When hotadd a new node, the node should be empty */
+	/* When hotadd a new node from cpu_up(), the node should be empty */
 	if (!node_start_pfn && !node_end_pfn)
 		return 0;
 
@@ -5118,7 +5118,7 @@ static unsigned long __meminit zone_absent_pages_in_node(int nid,
 	unsigned long zone_high = arch_zone_highest_possible_pfn[zone_type];
 	unsigned long zone_start_pfn, zone_end_pfn;
 
-	/* When hotadd a new node, the node should be empty */
+	/* When hotadd a new node from cpu_up(), the node should be empty */
 	if (!node_start_pfn && !node_end_pfn)
 		return 0;
 
-- 
2.0.0


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] memory-hotplug: fix comment in zone_spanned_pages_in_node() and zone_spanned_pages_in_node()
@ 2015-08-25  2:03 ` Xishi Qiu
  0 siblings, 0 replies; 4+ messages in thread
From: Xishi Qiu @ 2015-08-25  2:03 UTC (permalink / raw)
  To: Tang Chen, Yasuaki Ishimatsu, Andrew Morton, Naoya Horiguchi,
	Vlastimil Babka, mgorman, David Rientjes, Kamezawa Hiroyuki,
	izumi.taku
  Cc: LKML, Linux MM

When hotadd a node from add_memory(), we will add memblock first, so the
node is not empty. But when from cpu_up(), the node should be empty.

Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
---
 mm/page_alloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2ec3ca3..d370445 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5051,7 +5051,7 @@ static unsigned long __meminit zone_spanned_pages_in_node(int nid,
 {
 	unsigned long zone_start_pfn, zone_end_pfn;
 
-	/* When hotadd a new node, the node should be empty */
+	/* When hotadd a new node from cpu_up(), the node should be empty */
 	if (!node_start_pfn && !node_end_pfn)
 		return 0;
 
@@ -5118,7 +5118,7 @@ static unsigned long __meminit zone_absent_pages_in_node(int nid,
 	unsigned long zone_high = arch_zone_highest_possible_pfn[zone_type];
 	unsigned long zone_start_pfn, zone_end_pfn;
 
-	/* When hotadd a new node, the node should be empty */
+	/* When hotadd a new node from cpu_up(), the node should be empty */
 	if (!node_start_pfn && !node_end_pfn)
 		return 0;
 
-- 
2.0.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] memory-hotplug: fix comment in zone_spanned_pages_in_node() and zone_spanned_pages_in_node()
  2015-08-25  2:03 ` Xishi Qiu
@ 2015-08-25 23:35   ` David Rientjes
  -1 siblings, 0 replies; 4+ messages in thread
From: David Rientjes @ 2015-08-25 23:35 UTC (permalink / raw)
  To: Xishi Qiu
  Cc: Tang Chen, Yasuaki Ishimatsu, Andrew Morton, Naoya Horiguchi,
	Vlastimil Babka, mgorman, Kamezawa Hiroyuki, izumi.taku, LKML,
	Linux MM

On Tue, 25 Aug 2015, Xishi Qiu wrote:

> When hotadd a node from add_memory(), we will add memblock first, so the
> node is not empty. But when from cpu_up(), the node should be empty.
> 
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>

Acked-by: David Rientjes <rientjes@google.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] memory-hotplug: fix comment in zone_spanned_pages_in_node() and zone_spanned_pages_in_node()
@ 2015-08-25 23:35   ` David Rientjes
  0 siblings, 0 replies; 4+ messages in thread
From: David Rientjes @ 2015-08-25 23:35 UTC (permalink / raw)
  To: Xishi Qiu
  Cc: Tang Chen, Yasuaki Ishimatsu, Andrew Morton, Naoya Horiguchi,
	Vlastimil Babka, mgorman, Kamezawa Hiroyuki, izumi.taku, LKML,
	Linux MM

On Tue, 25 Aug 2015, Xishi Qiu wrote:

> When hotadd a node from add_memory(), we will add memblock first, so the
> node is not empty. But when from cpu_up(), the node should be empty.
> 
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>

Acked-by: David Rientjes <rientjes@google.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-25 23:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-25  2:03 [PATCH] memory-hotplug: fix comment in zone_spanned_pages_in_node() and zone_spanned_pages_in_node() Xishi Qiu
2015-08-25  2:03 ` Xishi Qiu
2015-08-25 23:35 ` David Rientjes
2015-08-25 23:35   ` David Rientjes

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.