From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: Re: [PATCH 1/7] phy: exynos-usb2: add vbus regulator support Date: Tue, 25 Aug 2015 07:47:31 +0200 Message-ID: <55DC0173.9030702@samsung.com> References: <1440160723-6636-1-git-send-email-m.szyprowski@samsung.com> <1440160723-6636-2-git-send-email-m.szyprowski@samsung.com> <55D71D3E.3010807@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <55D71D3E.3010807@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Kishon Vijay Abraham I , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Robert Baldyga , John Youn , Krzysztof Kozlowski , Kukjin Kim , Kamil Debski List-Id: linux-samsung-soc@vger.kernel.org Hello, On 2015-08-21 14:44, Kishon Vijay Abraham I wrote: > On Friday 21 August 2015 06:08 PM, Marek Szyprowski wrote: >> Exynos USB2 PHY has separate power supply, which is usually provided by >> VBUS regulator. This patch adds support for it. VBUS regulator is >> optional, to keep compatibility with boards, which have VBUS provided >> from some always-on power source. >> >> Signed-off-by: Marek Szyprowski >> --- >> .../devicetree/bindings/phy/samsung-phy.txt | 3 +++ >> drivers/phy/phy-samsung-usb2.c | 25 ++++++++++++++++++++-- >> drivers/phy/phy-samsung-usb2.h | 2 ++ >> 3 files changed, 28 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt >> index 60c6f2a633e0..0289d3b07853 100644 >> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt >> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt >> @@ -44,6 +44,9 @@ Required properties: >> - the "ref" clock is used to get the rate of the clock provided to the >> PHY module >> >> +Optional properties: >> +- vbus-supply: power-supply phandle for vbus power source > how about using phy-supply? I wanted to make it a bit more descriptive (vbus-supply is rather self explaining name) and keep it in line with Exynos usb3-drd phy, which already supports vbus-supply. If you think that this is a bad idea, a will use phy-supply then. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland