From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:50676 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755383AbbHYHeD (ORCPT ); Tue, 25 Aug 2015 03:34:03 -0400 Message-ID: <55DC1A3B.2010204@xs4all.nl> Date: Tue, 25 Aug 2015 09:33:15 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Mauro Carvalho Chehab , Linux Media Mailing List CC: Mauro Carvalho Chehab Subject: Re: [PATCH v7 19/44] [media] media: make link debug printk more generic References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: > Remove entity name from the link as this exists only if the object > type is PAD on both link ends. > > Signed-off-by: Mauro Carvalho Chehab I am wondering whether it should detect if this is a pad-to-pad link or an interface-to-entity link and log this accordingly. But I think that is better done as a follow-up patch if we think this is useful. So for this patch: Acked-by: Hans Verkuil > > diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c > index 9ec9c503caca..5788297cd500 100644 > --- a/drivers/media/media-entity.c > +++ b/drivers/media/media-entity.c > @@ -106,14 +106,12 @@ static void dev_dbg_obj(const char *event_name, struct media_gobj *gobj) > struct media_link *link = gobj_to_link(gobj); > > dev_dbg(gobj->mdev->dev, > - "%s: id 0x%08x link#%d: '%s' %s#%d ==> '%s' %s#%d\n", > + "%s: id 0x%08x link#%d: %s#%d ==> %s#%d\n", > event_name, gobj->id, media_localid(gobj), > > - link->source->entity->name, > gobj_type(media_type(&link->source->graph_obj)), > media_localid(&link->source->graph_obj), > > - link->sink->entity->name, > gobj_type(media_type(&link->sink->graph_obj)), > media_localid(&link->sink->graph_obj)); > break; >