All of lore.kernel.org
 help / color / mirror / Atom feed
From: Loic Poulain <loic.poulain@intel.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_h4: Fix zero len data packet reception issue
Date: Tue, 25 Aug 2015 10:09:40 +0200	[thread overview]
Message-ID: <55DC22C4.8070302@intel.com> (raw)
In-Reply-To: <6CD3A286-2B0E-4D93-A31B-49336A8AC37C@holtmann.org>

Hi Marcel,


> please give me an example of such a packet. I am currently failing to see what is wrong with the code and how this patch would actually help.
>
> Is this for vendor packet types or does this actually happen with standard H:4 packet types?


Yes, this is for some vendor specific packets.
For example, I have to deal with LPM packet with the following format:

|0xf1|opcode|dlen|data|

This kind of packet can be easily added to the h4_recv_pkt list.
However, some of these packets don't have any data (just PM ack packet):
0xf1|0x03|0x00

If we receive this packet, the h4_recv_buf function will retrieve the 
dlen (0) and just wait for more data. As long as there is not new data 
received (new packet), the LPM packet is not transmitted to the bt core.

Regards,
Loic


-- 
Intel Open Source Technology Center
http://oss.intel.com/

  reply	other threads:[~2015-08-25  8:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24 16:57 [PATCH] Bluetooth: hci_h4: Fix zero len data packet reception issue Loic Poulain
2015-08-24 18:19 ` Marcel Holtmann
2015-08-25  8:09   ` Loic Poulain [this message]
2015-08-25 15:01     ` Marcel Holtmann
2015-08-25 15:02 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DC22C4.8070302@intel.com \
    --to=loic.poulain@intel.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.