From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id DBBDCE00BE4; Tue, 25 Aug 2015 01:55:36 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [193.201.172.118 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (picmaster[at]mail.bg) * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mx2.mail.bg (mx2.mail.bg [193.201.172.118]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 13401E00978 for ; Tue, 25 Aug 2015 01:55:33 -0700 (PDT) Received: from [192.168.43.84] (85-118-69-17.mtel.net [85.118.69.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx2.mail.bg (Postfix) with ESMTPSA id C17C760030EA; Tue, 25 Aug 2015 11:55:31 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mail.bg; s=default; t=1440492932; bh=FF3/lndce/buWf/1CG475q2vYcaFOjosNqHI/FC80ek=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=DH2YrTBkejTy6f8fFv+lmZeSYKr74ywOJGB7K3xu+VPU5hUhN/BFPOjc1vk1KzpcY CdR4K0CCE+9O2DExSHKKyYzlQQyEjqXZCWn0x/DJcZI7XjTOsfy4LnqBYCHMD2q74K EOPwEwhvmsKSmJUldT/lnWNoeSxWs0G0Xr5AIX3U= Message-ID: <55DC2D80.80908@mail.bg> Date: Tue, 25 Aug 2015 11:55:28 +0300 From: Nikolay Dimitrov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Otavio Salvador References: <1440167886-20156-1-git-send-email-b54851@freescale.com> In-Reply-To: Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-arm][PATCH v8] pulseaudio: Add PulseAudio configuration X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2015 08:55:36 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Hi Otavio, On 08/22/2015 12:16 AM, Otavio Salvador wrote: > On Fri, Aug 21, 2015 at 11:38 AM, Yuqing Zhu wrote: >> +IMX_PATCHES = " file://daemon.conf \ >> + file://default.pa \ >> +" >> +SRC_URI_append_mx6 = "${IMX_PATCHES}" >> +SRC_URI_append_mx7 = "${IMX_PATCHES}" > > I see no need to add a new variable for such simple append. You can > rewrite this as: > > SRC_URI_append_mx6 = " file://daemon.conf file://default.pa" > SRC_URI_append_mx7 = " file://daemon.conf file://default.pa" The only wrong thing here is the variable name (IMX_PATCHES), as these are config files and not patches. A better one would be IMX_PA_CONFIGS. The change you proposed will now force the developer to duplicate and manually keep in sync the 2 lists of config files. Regards, Nikolay