All of lore.kernel.org
 help / color / mirror / Atom feed
From: Edward Shishkin <edward.shishkin@gmail.com>
To: Reiserfs development mailing list <reiserfs-devel@vger.kernel.org>
Subject: [PATCH] reiser4progs: Grab pset after skipping the semantic pass by fsck
Date: Tue, 25 Aug 2015 17:50:40 +0200	[thread overview]
Message-ID: <55DC8ED0.1020806@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: reiser4progs-grab-pset-after-skipping-semantic-path.patch --]
[-- Type: text/x-patch, Size: 847 bytes --]

Init global pset in the case when semantic pass is skipped
because of fatal corruptions. Otherwise fsck segfaults on
volumes of format versions 4.0.1 when reopening a backup
at fsck_check_fini().

Signed-off-by: Edward Shishkin <edward.shishkin@gmail.com>
---
 librepair/repair.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

--- a/librepair/repair.c
+++ b/librepair/repair.c
@@ -786,8 +786,14 @@ errno_t repair_check(repair_data_t *repa
 	if (repair->fatal) {
 		aal_warn("Fatal corruptions were found. "
 			 "Semantic pass is skipped.");
+		/*
+		 * We need to prepare pset for backup
+		 * creation in fsck_check_fini().
+		 */
+		if (res = reiser4_pset_tree(control.repair->fs->tree, 0))
+			goto error;
 		goto update;
-	} 
+	}
 	
 	/* Check the semantic reiser4 tree. */
 	if ((res = repair_sem_prepare(&control, &sem)))

                 reply	other threads:[~2015-08-25 15:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DC8ED0.1020806@gmail.com \
    --to=edward.shishkin@gmail.com \
    --cc=reiserfs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.