From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Peng Tao <tao.peng@primarydata.com>, <linux-nfs@vger.kernel.org>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
Christoph Hellwig <hch@infradead.org>, Zach Brown <zab@zabbo.net>,
Darren Hart <dvhart@linux.intel.com>, <bfields@fieldses.org>,
Jeff Layton <jeff.layton@primarydata.com>
Subject: Re: [PATCH RFC 03/11] nfs42: decode_layoutstats does not need res parameter
Date: Tue, 25 Aug 2015 12:04:18 -0400 [thread overview]
Message-ID: <55DC9202.3080203@Netapp.com> (raw)
In-Reply-To: <1440516829-116041-4-git-send-email-tao.peng@primarydata.com>
Hey Tao,
Should this be sent as a separate patch? It could probably be included now, rather than waiting on the rest of the CLONE patches to filter through.
Thanks,
Anna
On 08/25/2015 11:33 AM, Peng Tao wrote:
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Peng Tao <tao.peng@primarydata.com>
> ---
> fs/nfs/nfs42xdr.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/nfs/nfs42xdr.c b/fs/nfs/nfs42xdr.c
> index a6bd27d..0eb29e1 100644
> --- a/fs/nfs/nfs42xdr.c
> +++ b/fs/nfs/nfs42xdr.c
> @@ -238,8 +238,7 @@ out_overflow:
> return -EIO;
> }
>
> -static int decode_layoutstats(struct xdr_stream *xdr,
> - struct nfs42_layoutstat_res *res)
> +static int decode_layoutstats(struct xdr_stream *xdr)
> {
> return decode_op_hdr(xdr, OP_LAYOUTSTATS);
> }
> @@ -343,7 +342,7 @@ static int nfs4_xdr_dec_layoutstats(struct rpc_rqst *rqstp,
> goto out;
> WARN_ON(res->num_dev > PNFS_LAYOUTSTATS_MAXDEV);
> for (i = 0; i < res->num_dev; i++) {
> - status = decode_layoutstats(xdr, res);
> + status = decode_layoutstats(xdr);
> if (status)
> goto out;
> }
>
next prev parent reply other threads:[~2015-08-25 16:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 15:33 [PATCH RFC 00/11] NFS/NFSD: add NFSv42 COPY operation support Peng Tao
2015-08-25 15:33 ` [PATCH RFC 01/11] vfs: pull btrfs clone API to vfs layer Peng Tao
2015-08-25 15:33 ` Peng Tao
2015-08-26 1:40 ` Peng Tao
2015-08-26 1:50 ` Dave Chinner
2015-08-26 1:59 ` Dave Chinner
2015-08-26 4:09 ` Darrick J. Wong
2015-08-26 8:03 ` Peng Tao
2015-08-26 8:03 ` Peng Tao
2015-08-25 15:33 ` [PATCH RFC 02/11] vfs/btrfs: add .clone_range file operation Peng Tao
2015-08-26 8:01 ` David Sterba
2015-08-26 8:01 ` David Sterba
2015-08-26 8:31 ` Peng Tao
2015-08-26 8:31 ` Peng Tao
2015-08-26 13:00 ` David Sterba
2015-08-26 13:00 ` David Sterba
2015-08-26 13:07 ` Christoph Hellwig
2015-08-25 15:33 ` [PATCH RFC 03/11] nfs42: decode_layoutstats does not need res parameter Peng Tao
2015-08-25 16:04 ` Anna Schumaker [this message]
2015-08-25 15:33 ` [PATCH RFC 04/11] nfs42: remove unused declaration Peng Tao
2015-08-25 16:05 ` Anna Schumaker
2015-08-25 16:08 ` Peng Tao
2015-08-25 15:33 ` [PATCH RFC 05/11] nfs42: add CLONE xdr functions Peng Tao
2015-08-25 15:33 ` [PATCH RFC 06/11] nfs42: add CLONE proc functions Peng Tao
2015-08-25 15:33 ` [PATCH RFC 07/11] nfs42: add .copy_range file operation Peng Tao
2015-08-25 15:33 ` [PATCH RFC 08/11] nfs: get clone_blksize when probing fsinfo Peng Tao
2015-08-25 15:33 ` [PATCH RFC 09/11] nfs42: respect clone_blksize Peng Tao
2015-08-25 15:33 ` [PATCH RFC 10/11] nfsd: Pass filehandle to nfs4_preprocess_stateid_op() Peng Tao
2015-08-25 15:33 ` [PATCH RFC 11/11] NFSD: Implement the CLONE call Peng Tao
2015-08-25 22:09 ` J. Bruce Fields
2015-08-25 22:11 ` J. Bruce Fields
2015-08-26 1:33 ` Peng Tao
2015-08-25 15:42 ` [PATCH RFC 00/11] NFS/NFSD: add NFSv42 COPY operation support Peng Tao
2015-08-25 16:01 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DC9202.3080203@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=dvhart@linux.intel.com \
--cc=hch@infradead.org \
--cc=jeff.layton@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=tao.peng@primarydata.com \
--cc=trond.myklebust@primarydata.com \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.