From: Matthias Tafelmeier <matthias.tafelmeier@gmx.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, hagen@jauu.net, shemminger@osdl.org,
fw@strlen.de, edumazet@google.com, daniel@iogearbox.net
Subject: Re: [PATCH v3 01/10] ss: rooted out ss type declarations for output formatters
Date: Tue, 25 Aug 2015 21:13:01 +0200 [thread overview]
Message-ID: <55DCBE3D.20206@gmx.net> (raw)
In-Reply-To: <20150823100758.74a626d4@urahara>
On 08/23/2015 07:07 PM, Stephen Hemminger wrote:
> On Thu, 20 Aug 2015 22:40:12 +0200
> Matthias Tafelmeier <matthias.tafelmeier@gmx.net> wrote:
>
>> The prospected output formatters and ss do share type declarations like
>> slabstat or tcpstat so that the decision has been made to centralize
>> those declarations in ss_types.h. Potential future declarations shall
>> be placed there. The latter should help amend the extent of ss.c as
>> well.
>>
>> Signed-off-by: Matthias Tafelmeier <matthias.tafelmeier@gmx.net>
>> Suggested-by: Hagen Paul Pfeifer <hagen@jauu.net>
>
> I looked at this series, and was going to merge it but the code to do
> json formatting gets really ugly. Please redo it with the json_writer
> code I just added.
>
Original: "See your point there. I will do that. Thanks."
Had a glitch with my email-client. This time without PGP.
next prev parent reply other threads:[~2015-08-25 19:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 20:40 [PATCH v3]iproute2: full ss json support and general output simplification Matthias Tafelmeier
2015-08-20 20:40 ` [PATCH v3 01/10] ss: rooted out ss type declarations for output formatters Matthias Tafelmeier
2015-08-23 17:07 ` Stephen Hemminger
2015-08-24 18:40 ` Matthias Tafelmeier
2015-08-25 19:13 ` Matthias Tafelmeier [this message]
2015-08-20 20:40 ` [PATCH v3 02/10] ss: created formatters for json and hr Matthias Tafelmeier
2015-08-20 20:40 ` [PATCH v3 03/10] ss: removed obsolet fmt functions Matthias Tafelmeier
2015-08-20 20:40 ` [PATCH v3 04/10] ss: prepare timer for output handler usage Matthias Tafelmeier
2015-08-20 20:40 ` [PATCH v3 05/10] ss: framed skeleton for json output in ss Matthias Tafelmeier
2015-08-20 20:40 ` [PATCH v3 06/10] ss: replaced old output mechanisms with fmt handlers interfaces Matthias Tafelmeier
2015-08-20 20:40 ` [PATCH v3 07/10] ss: renaming and export of current_filter Matthias Tafelmeier
2015-08-20 20:40 ` [PATCH v3 08/10] ss: symmetrical formatter extension example Matthias Tafelmeier
2015-08-20 20:40 ` [PATCH v3 09/10] ss: symmetrical subhandler output " Matthias Tafelmeier
2015-08-20 20:40 ` [PATCH v3 10/10] ss: fixed free on local array for valid json output Matthias Tafelmeier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DCBE3D.20206@gmx.net \
--to=matthias.tafelmeier@gmx.net \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=hagen@jauu.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.