From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756218AbbHYVMr (ORCPT ); Tue, 25 Aug 2015 17:12:47 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:35517 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755980AbbHYVMo (ORCPT ); Tue, 25 Aug 2015 17:12:44 -0400 Subject: Re: [PATCH] usb: message: remove redundant declaration To: Kris Borer , gregkh@linuxfoundation.org References: <1440469808-3505-1-git-send-email-kborer@gmail.com> Cc: stefan.koch10@gmail.com, lkml14@scotdoyle.com, stern@rowland.harvard.edu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <55DCDA49.9040308@cogentembedded.com> Date: Wed, 26 Aug 2015 00:12:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1440469808-3505-1-git-send-email-kborer@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 08/25/2015 05:30 AM, Kris Borer wrote: > Fix the Sparse warning: > > message.c:1390:21: warning: symbol 'i' shadows an earlier one > message.c:1294:13: originally declared here > > Signed-off-by: Kris Borer > --- > drivers/usb/core/message.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c > index f368d20..e83648d 100644 > --- a/drivers/usb/core/message.c > +++ b/drivers/usb/core/message.c > @@ -1387,7 +1387,6 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate) > * new altsetting. > */ > if (manual) { > - int i; > Why not remove (now unneeded) empty line? > for (i = 0; i < alt->desc.bNumEndpoints; i++) { > epaddr = alt->endpoint[i].desc.bEndpointAddress; MBR, Sergei