From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v2 1/6] ARM: dts: ifc6410: Add pwrseq support for WLAN Date: Tue, 25 Aug 2015 14:33:13 -0700 Message-ID: <55DCDF19.4070901@codeaurora.org> References: <1439903069-19752-1-git-send-email-srinivas.kandagatla@linaro.org> <1439903212-19931-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1439903212-19931-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Srinivas Kandagatla Cc: agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org On 08/18/2015 06:06 AM, Srinivas Kandagatla wrote: > @@ -10,6 +11,20 @@ > serial1 = &gsbi6_serial; > }; > > + pwrseq { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; Why do we need any of these three properties? > + compatible = "simple-bus"; > + > + sdcc4_pwrseq: sdcc4_pwrseq { > + pinctrl-names = "default"; > + pinctrl-0 = <&wlan_default_gpios>; > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&pm8921_gpio 43 GPIO_ACTIVE_LOW>; Especially because this node doesn't have a reg property. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Tue, 25 Aug 2015 14:33:13 -0700 Subject: [PATCH v2 1/6] ARM: dts: ifc6410: Add pwrseq support for WLAN In-Reply-To: <1439903212-19931-1-git-send-email-srinivas.kandagatla@linaro.org> References: <1439903069-19752-1-git-send-email-srinivas.kandagatla@linaro.org> <1439903212-19931-1-git-send-email-srinivas.kandagatla@linaro.org> Message-ID: <55DCDF19.4070901@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/18/2015 06:06 AM, Srinivas Kandagatla wrote: > @@ -10,6 +11,20 @@ > serial1 = &gsbi6_serial; > }; > > + pwrseq { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; Why do we need any of these three properties? > + compatible = "simple-bus"; > + > + sdcc4_pwrseq: sdcc4_pwrseq { > + pinctrl-names = "default"; > + pinctrl-0 = <&wlan_default_gpios>; > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&pm8921_gpio 43 GPIO_ACTIVE_LOW>; Especially because this node doesn't have a reg property. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756106AbbHYVdR (ORCPT ); Tue, 25 Aug 2015 17:33:17 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56704 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755749AbbHYVdP (ORCPT ); Tue, 25 Aug 2015 17:33:15 -0400 Message-ID: <55DCDF19.4070901@codeaurora.org> Date: Tue, 25 Aug 2015 14:33:13 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Srinivas Kandagatla CC: agross@codeaurora.org, linux-arm-msm@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] ARM: dts: ifc6410: Add pwrseq support for WLAN References: <1439903069-19752-1-git-send-email-srinivas.kandagatla@linaro.org> <1439903212-19931-1-git-send-email-srinivas.kandagatla@linaro.org> In-Reply-To: <1439903212-19931-1-git-send-email-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/18/2015 06:06 AM, Srinivas Kandagatla wrote: > @@ -10,6 +11,20 @@ > serial1 = &gsbi6_serial; > }; > > + pwrseq { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; Why do we need any of these three properties? > + compatible = "simple-bus"; > + > + sdcc4_pwrseq: sdcc4_pwrseq { > + pinctrl-names = "default"; > + pinctrl-0 = <&wlan_default_gpios>; > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&pm8921_gpio 43 GPIO_ACTIVE_LOW>; Especially because this node doesn't have a reg property. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project