From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux Date: Tue, 25 Aug 2015 19:44:51 -0600 Message-ID: <55DD1A13.7010705@wwwdotorg.org> References: <1440405608-3995-1-git-send-email-kernel@martin.sperl.org> <1440405608-3995-4-git-send-email-kernel@martin.sperl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Lee Jones , Russell King , Mark Brown , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ian Campbell , Rob Herring , Pawel Moll , Kumar Gala To: kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org Return-path: In-Reply-To: <1440405608-3995-4-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 08/24/2015 02:40 AM, kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org wrote: > From: Martin Sperl Patch description? > diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-aux.txt b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-aux.txt > +Required properties: > +- compatible: Should be "brcm,bcm2835-aux". > +- reg: Should contain register location and length for the > + enable register As I mentioned before, why not all the aux registers (that aren't part of a sub-device like SPI). > +Example: > + > +aux_enable: aux_enable@0x7e215004 { > + compatible = "bcrm,bcm2835-aux"; > + reg = <0x7e215004 0x04>; I'd expect that to be <0x7e215000 0x8>; -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Tue, 25 Aug 2015 19:44:51 -0600 Subject: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux In-Reply-To: <1440405608-3995-4-git-send-email-kernel@martin.sperl.org> References: <1440405608-3995-1-git-send-email-kernel@martin.sperl.org> <1440405608-3995-4-git-send-email-kernel@martin.sperl.org> Message-ID: <55DD1A13.7010705@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/24/2015 02:40 AM, kernel at martin.sperl.org wrote: > From: Martin Sperl Patch description? > diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-aux.txt b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-aux.txt > +Required properties: > +- compatible: Should be "brcm,bcm2835-aux". > +- reg: Should contain register location and length for the > + enable register As I mentioned before, why not all the aux registers (that aren't part of a sub-device like SPI). > +Example: > + > +aux_enable: aux_enable at 0x7e215004 { > + compatible = "bcrm,bcm2835-aux"; > + reg = <0x7e215004 0x04>; I'd expect that to be <0x7e215000 0x8>; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933020AbbHZBo4 (ORCPT ); Tue, 25 Aug 2015 21:44:56 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:58276 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751859AbbHZBoy (ORCPT ); Tue, 25 Aug 2015 21:44:54 -0400 Message-ID: <55DD1A13.7010705@wwwdotorg.org> Date: Tue, 25 Aug 2015 19:44:51 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: kernel@martin.sperl.org CC: Lee Jones , Russell King , Mark Brown , Mark Rutland , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, Ian Campbell , Rob Herring , Pawel Moll , Kumar Gala Subject: Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux References: <1440405608-3995-1-git-send-email-kernel@martin.sperl.org> <1440405608-3995-4-git-send-email-kernel@martin.sperl.org> In-Reply-To: <1440405608-3995-4-git-send-email-kernel@martin.sperl.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24/2015 02:40 AM, kernel@martin.sperl.org wrote: > From: Martin Sperl Patch description? > diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-aux.txt b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-aux.txt > +Required properties: > +- compatible: Should be "brcm,bcm2835-aux". > +- reg: Should contain register location and length for the > + enable register As I mentioned before, why not all the aux registers (that aren't part of a sub-device like SPI). > +Example: > + > +aux_enable: aux_enable@0x7e215004 { > + compatible = "bcrm,bcm2835-aux"; > + reg = <0x7e215004 0x04>; I'd expect that to be <0x7e215000 0x8>;