From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH 2/3] serial: 8250_omap: check how many bytes were injected Date: Wed, 26 Aug 2015 15:08:01 +0530 Message-ID: <55DD88F9.6010003@ti.com> References: <1439568064-7907-1-git-send-email-bigeasy@linutronix.de> <1439568064-7907-2-git-send-email-bigeasy@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1439568064-7907-2-git-send-email-bigeasy@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Sebastian Andrzej Siewior , peter@hurleysoftware.com Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-serial@vger.kernel.org, john.ogness@linutronix.de, Greg Kroah-Hartman List-Id: linux-omap@vger.kernel.org On Friday 14 August 2015 09:31 PM, Sebastian Andrzej Siewior wrote: > The function tty_insert_flip_string() returns an int and as such it > might fail. So the result is that I kindly asked to insert 48 bytes and > the function only insterted 32. > I have no idea what to do with the remaining 16 so I think dropping them > is the only option. I also increase the buf_overrun counter so userpace > has a clue that we lost bytes. > > Cc: Greg Kroah-Hartman > Signed-off-by: Sebastian Andrzej Siewior Tested with wilink BT module on TI's DRA7 EVM. Tested-by: Sekhar Nori Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756740AbbHZJiS (ORCPT ); Wed, 26 Aug 2015 05:38:18 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:47765 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbbHZJiO (ORCPT ); Wed, 26 Aug 2015 05:38:14 -0400 Message-ID: <55DD88F9.6010003@ti.com> Date: Wed, 26 Aug 2015 15:08:01 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Sebastian Andrzej Siewior , CC: , , , , Greg Kroah-Hartman Subject: Re: [PATCH 2/3] serial: 8250_omap: check how many bytes were injected References: <1439568064-7907-1-git-send-email-bigeasy@linutronix.de> <1439568064-7907-2-git-send-email-bigeasy@linutronix.de> In-Reply-To: <1439568064-7907-2-git-send-email-bigeasy@linutronix.de> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 14 August 2015 09:31 PM, Sebastian Andrzej Siewior wrote: > The function tty_insert_flip_string() returns an int and as such it > might fail. So the result is that I kindly asked to insert 48 bytes and > the function only insterted 32. > I have no idea what to do with the remaining 16 so I think dropping them > is the only option. I also increase the buf_overrun counter so userpace > has a clue that we lost bytes. > > Cc: Greg Kroah-Hartman > Signed-off-by: Sebastian Andrzej Siewior Tested with wilink BT module on TI's DRA7 EVM. Tested-by: Sekhar Nori Thanks, Sekhar