From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/tn5250: fix static linking problem
Date: Wed, 26 Aug 2015 12:29:28 +0100 [thread overview]
Message-ID: <55DDA318.2050008@imgtec.com> (raw)
In-Reply-To: <20150826111255.GI8919@tarshish>
Dear Baruch Siach,
On 08/26/2015 12:12 PM, Baruch Siach wrote:
> Hi Vicente,
>
> On Wed, Aug 26, 2015 at 12:04:09PM +0100, Vicente Olivert Riera wrote:
>> On 08/26/2015 11:32 AM, Baruch Siach wrote:
>>> On Wed, Aug 26, 2015 at 10:09:31AM +0100, Vicente Olivert Riera wrote:
>>>> On 08/26/2015 10:08 AM, Baruch Siach wrote:
>>>>> On Wed, Aug 26, 2015 at 09:59:51AM +0100, Vicente Olivert Riera wrote:
>>>>>> ifeq ($(BR2_PACKAGE_OPENSSL),y)
>>>>>> +TN5250_CONF_ENV += LIBS="-lssl -lcrypto -lz"
>>>>>
>>>>> Please use pkg-config. See package/vsftpd/vsftpd.mk for example.
>>>>
>>>> that was my first approach and it didn't work. Does it work for you?
>>>
>>> Please try http://patchwork.ozlabs.org/patch/510797/. Works for me :-).
>>
>> yeah, that one works. I was missing "libcrypto". But, I don't understand
>> why do you need to put libcrypto manually since it's already listed in
>> the openssl.pc file, and then libcrypto pulls libz. Doesn't work
>> recursively?
>
> I tried "--libs openssl" here, and it works as well. I'm not sure which one is
> better.
>
> baruch
>
indeed, it works. Now I'm wondering which which mistake I made.
I think just "--libs openssl" is better since it seems to act
recursively and pull all the other libraries as well. If you send a v2
of your patch, you can keep my reviewed-by and my tested-by, since I
have already done the test.
Regards,
Vincent.
next prev parent reply other threads:[~2015-08-26 11:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 8:59 [Buildroot] [PATCH] package/tn5250: fix static linking problem Vicente Olivert Riera
2015-08-26 9:08 ` Baruch Siach
2015-08-26 9:09 ` Vicente Olivert Riera
2015-08-26 10:32 ` Baruch Siach
2015-08-26 11:04 ` Vicente Olivert Riera
2015-08-26 11:12 ` Baruch Siach
2015-08-26 11:29 ` Vicente Olivert Riera [this message]
2015-08-26 11:32 ` Vicente Olivert Riera
2015-08-26 11:39 ` Baruch Siach
2015-08-26 21:26 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DDA318.2050008@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.