From: Peter Hurley <peter@hurleysoftware.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-serial@vger.kernel.org, john.ogness@linutronix.de,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/3] serial: 8250: move rx_running out of the bitfield
Date: Wed, 26 Aug 2015 08:43:55 -0400 [thread overview]
Message-ID: <55DDB48B.80701@hurleysoftware.com> (raw)
In-Reply-To: <55DD88E2.3000401@ti.com>
On 08/26/2015 05:37 AM, Sekhar Nori wrote:
> On Friday 14 August 2015 09:31 PM, Sebastian Andrzej Siewior wrote:
>> From: John Ogness <john.ogness@linutronix.de>
>>
>> That bitfield is modified by read + or + write operation. If someone
>> sets any of the other two bits it might render the lock useless.
>>
>> While at it, remove other bitfields as well to avoid more such
>> errors.
>>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Signed-off-by: John Ogness <john.ogness@linutronix.de>
>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> Tested with wilink BT module on TI's DRA7 EVM.
>
> Tested-by: Sekhar Nori <nsekhar@ti.com>
Already in Greg's tty-next tree (and 4.3-rc1 pull request), Sekhar.
Regards,
Peter Hurley
next prev parent reply other threads:[~2015-08-26 12:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 16:01 [PATCH 1/3] serial: 8250: move rx_running out of the bitfield Sebastian Andrzej Siewior
2015-08-14 16:01 ` [PATCH 2/3] serial: 8250_omap: check how many bytes were injected Sebastian Andrzej Siewior
2015-08-26 9:38 ` Sekhar Nori
2015-08-26 9:38 ` Sekhar Nori
2015-08-26 12:44 ` Peter Hurley
2015-08-26 13:01 ` Sekhar Nori
2015-08-26 13:01 ` Sekhar Nori
2015-08-14 16:01 ` [RFC 3/3] serial: 8250_omap: try to avoid IER_RDI with DMA Sebastian Andrzej Siewior
2015-08-26 9:12 ` Sekhar Nori
2015-08-26 9:12 ` Sekhar Nori
2015-08-26 9:37 ` [PATCH 1/3] serial: 8250: move rx_running out of the bitfield Sekhar Nori
2015-08-26 9:37 ` Sekhar Nori
2015-08-26 12:43 ` Peter Hurley [this message]
2015-08-26 12:58 ` Sekhar Nori
2015-08-26 12:58 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DDB48B.80701@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.