Re: [Qemu-devel] [PATCH v4 3/7] crypto: introduce new module for TLS x509 credentials

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

On 08/24/2015 08:14 AM, Daniel P. Berrange wrote:
> Introduce a QCryptoTLSCredsX509 class which is used to
> manage x509 certificate TLS credentials. This will be
> the preferred credential type offering strong security
> characteristics
> 
> Example CLI configuration:
> 
>  $QEMU -object tls-creds-x509,id=tls0,endpoint=server,\
>                dir=/path/to/creds/dir,verify-peer=yes
> 
> The 'id' value in the -object args will be used to associate the
> credentials with the network services. For eample, when the VNC

s/eample/example/

> server is later converted it would use
> 
>  $QEMU -object tls-creds-x509,id=tls0,.... \
>        -vnc 127.0.0.1:1,tls-creds=tls0
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---

> +/* #define QCRYPTO_DEBUG */
> +
> +#ifdef QCRYPTO_DEBUG
> +#define DPRINTF(fmt, ...) do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0)
> +#else
> +#define DPRINTF(fmt, ...) do { } while (0)
> +#endif

/me I said I wouldn't point it out further... Must Resist...

Otherwise looks okay.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]