All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2/2] hwmon: The Code Crashes
Date: Wed, 26 Aug 2015 15:26:25 +0000	[thread overview]
Message-ID: <55DDDAA1.6010502@roeck-us.net> (raw)
In-Reply-To: <1440567719-27643-2-git-send-email-corone.il.han@gmail.com>

On 08/26/2015 07:56 AM, Il Han wrote:
> 2015-08-26 23:06 GMT+09:00 Guenter Roeck <linux@roeck-us.net <mailto:linux@roeck-us.net>>:
>
>     On 08/25/2015 10:41 PM, Il Han wrote:
>
>         The code crashes, since dev is not an i2c client device.
>
>         Signed-off-by: Il Han <corone.il.han@gmail.com <mailto:corone.il.han@gmail.com>>
>
>
>     You lost me a bit here. Why did you make this a separate patch ?
>
>     Also, please version your patches and provide a change log.
>     I am sure I asked for that before.
>
>     Thanks,
>     Guenter
>
>
> Sorry.
> Because I'm not accustomed to commit them with git, I made the mistake.
> confused about making a patch version such as [PATCH v2], providing a change log, etc.
> I am going to look up about git commit.

You might be looking for
	git format-patch --subject-prefix="PATCH v2"

Providing a change log doesn't mean to provide separate patches. It means
to tag the patch with a version number ("PATCH v2" instead of "PATCH"),
and to describe the changes below the '---' line in the patch.
This is described in detail in Documentation/SubmittingPatches.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2015-08-26 15:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-26  5:41 [lm-sensors] [PATCH 2/2] hwmon: The Code Crashes Il Han
2015-08-26 14:06 ` Guenter Roeck
2015-08-26 14:56 ` Il Han
2015-08-26 15:26 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DDDAA1.6010502@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.