From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUelz-0005vg-Hq for qemu-devel@nongnu.org; Wed, 26 Aug 2015 13:46:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUelw-00076m-2r for qemu-devel@nongnu.org; Wed, 26 Aug 2015 13:46:07 -0400 Received: from mail-db3on0065.outbound.protection.outlook.com ([157.55.234.65]:56120 helo=emea01-db3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUelv-00076I-Qo for qemu-devel@nongnu.org; Wed, 26 Aug 2015 13:46:04 -0400 References: <1440433079-14458-1-git-send-email-rth@twiddle.net> <1440433079-14458-8-git-send-email-rth@twiddle.net> From: Chris Metcalf Message-ID: <55DDF34C.2020507@ezchip.com> Date: Wed, 26 Aug 2015 13:11:40 -0400 MIME-Version: 1.0 In-Reply-To: <1440433079-14458-8-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v14 07/33] target-tilegx: Fix LDNA_ADD_IMM8_OPCODE_X1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: walt@tilera.com, xili_gchen_5257@hotmail.com, peter.maydell@linaro.org I have queued both this and the 06/33 patch in the linux-tile tree as a single patch for the kernel when the 4.3 merge window opens, with Richard's Reported-By. Thanks! Both of these appear to be cut-and-paste errors from the tilepro versions of the files. On 08/24/2015 12:17 PM, Richard Henderson wrote: > An obvious typo in the mnemonic here. > > Signed-off-by: Richard Henderson > --- > target-tilegx/opcode_tilegx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-tilegx/opcode_tilegx.h b/target-tilegx/opcode_tilegx.h > index 3b8bf4f..989436d 100644 > --- a/target-tilegx/opcode_tilegx.h > +++ b/target-tilegx/opcode_tilegx.h > @@ -1015,7 +1015,7 @@ enum > LD_UNARY_OPCODE_X1 = 29, > LNK_UNARY_OPCODE_X1 = 30, > LNK_UNARY_OPCODE_Y1 = 14, > - LWNA_ADD_IMM8_OPCODE_X1 = 21, > + LDNA_ADD_IMM8_OPCODE_X1 = 21, > MFSPR_IMM8_OPCODE_X1 = 22, > MF_UNARY_OPCODE_X1 = 31, > MM_BF_OPCODE_X0 = 7, -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com