From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36739)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1ZUfm0-0002jB-JW
	for qemu-devel@nongnu.org; Wed, 26 Aug 2015 14:50:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1ZUflx-0007IN-Ds
	for qemu-devel@nongnu.org; Wed, 26 Aug 2015 14:50:12 -0400
Received: from mx2.parallels.com ([199.115.105.18]:50301)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1ZUflx-0007ID-8a
	for qemu-devel@nongnu.org; Wed, 26 Aug 2015 14:50:09 -0400
References: <1440583525-21632-1-git-send-email-marcandre.lureau@redhat.com>
	<1440583525-21632-6-git-send-email-marcandre.lureau@redhat.com>
	<55DE00EE.9080600@parallels.com>
	<1569455872.1683587.1440613054232.JavaMail.zimbra@redhat.com>
	<55DE051D.60805@parallels.com>
	<CAJ+F1CL9cfo3zXy+h_iZHOz1z_Smv7zENVJ8bpxvBSNnVfA_6Q@mail.gmail.com>
From: "Denis V. Lunev" <den-lists@parallels.com>
Message-ID: <55DE0A54.60104@parallels.com>
Date: Wed, 26 Aug 2015 21:49:56 +0300
MIME-Version: 1.0
In-Reply-To: <CAJ+F1CL9cfo3zXy+h_iZHOz1z_Smv7zENVJ8bpxvBSNnVfA_6Q@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>, Michael Roth <mdroth@linux.vnet.ibm.com>

On 08/26/2015 09:41 PM, Marc-André Lureau wrote:
> On Wed, Aug 26, 2015 at 8:27 PM, Denis V. Lunev <den-lists@parallels.com> wrote:
>> lets consider this patch. You have done 2 things:
>> - changed initialisation order and dropped nasty temporary variables
>> - introduced alloc/free code
>>
>> But in the next patch each line with alloc/free code
>> will be changed due to variable rename and
>> moving to the separate function (free), which
>> IMHO means that this preparatory step is unnecessary,
>> you will make almost same changes in the next
>> patch
> to me this patch is a preparatory cleanup, having variable initialized
> to NULL, string allocated, and free. The nice side effect is that we
> can get rid of the weird fixed_state_dir stuff.
>
>> Thus the sum of changes in this patch/next patch
>> would be less with uncovering initialization
>> change details, which are missed in the patch
>> description
> I agree I can complete the commit description, but I think it's best
> to keep this preparatory cleanup.
>
yep. This is good to me.