From: Daniel Borkmann <daniel@iogearbox.net>
To: Alexei Starovoitov <ast@plumgrid.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: sched: consolidate tc_classify{,_compat}
Date: Thu, 27 Aug 2015 00:02:30 +0200 [thread overview]
Message-ID: <55DE3776.2060700@iogearbox.net> (raw)
In-Reply-To: <55DE357D.7010800@plumgrid.com>
On 08/26/2015 11:54 PM, Alexei Starovoitov wrote:
> On 8/26/15 2:00 PM, Daniel Borkmann wrote:
...
>> +reset:
>> + if (unlikely(limit++ >= MAX_REC_LOOP)) {
>> + net_notice_ratelimited("%s: reclassify loop, rule prio %u, "
>> + "protocol %02x\n", tp->q->ops->id,
>> + tp->prio & 0xffff, ntohs(tp->protocol));
>
> why drop 'packet' and add two extra ',' in the message ?
> Not a big deal, just why bother?
No deep underlying reason, thought it would make it slightly
more readable.
next prev parent reply other threads:[~2015-08-26 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 21:00 [PATCH net-next] net: sched: consolidate tc_classify{,_compat} Daniel Borkmann
2015-08-26 21:54 ` Alexei Starovoitov
2015-08-26 22:02 ` Daniel Borkmann [this message]
2015-08-27 21:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DE3776.2060700@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.