From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=YBL8RTl7wbpirBloRXMmbAg6UzwqHsaATJaKZ6ZfcjM=; b=eEzkgqw1+lmel9wgQxgyG/Wwz5EZXx3rolQUUpbA1OGIFVjfCclQO9KbL+zI7QzsxJ jAnxbNrdSLfdDU1YkUiXuX7gCDx6x4CdtjgPJRjw6A0HUt5aomjvkmlbPBKw3zK03M7A 3HYnnZuurQ/63cJzKSi3AW79qVrIjbDZTuxXo= Message-ID: <55DE98AF.8000503@cumulusnetworks.com> Date: Wed, 26 Aug 2015 21:57:19 -0700 From: roopa MIME-Version: 1.0 References: <1440549295-3979-1-git-send-email-razor@blackwall.org> <20150825.194222.390859854071446877.davem@davemloft.net> <20150825.230641.773630246486190390.davem@davemloft.net> In-Reply-To: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Subject: Re: [Bridge] [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikolay Aleksandrov Cc: vyasevic@redhat.com, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, wkok@cumulusnetworks.com, David Miller On 8/26/15, 4:33 AM, Nikolay Aleksandrov wrote: >> On Aug 25, 2015, at 11:06 PM, David Miller wrote: >> >> From: Nikolay Aleksandrov >> Date: Tue, 25 Aug 2015 22:28:16 -0700 >> >>> Certainly, that should be done and I will look into it, but the >>> essence of this patch is a bit different. The problem here is not >>> the size of the fdb entries, it’s more the number of them - having >>> 96000 entries (even if they were 1 byte ones) is just way too much >>> especially when the fdb hash size is small and static. We could work >>> on making it dynamic though, but still these type of local entries >>> per vlan per port can easily be avoided with this option. >> 96000 bits can be stored in 12k. Get where I'm going with this? >> >> Look at the problem sideways. > Oh okay, I misunderstood your previous comment. I’ll look into that. > I just wanted to add the other problems we have had with keeping these macs (mostly from userspace POV): - add/del netlink notification storms - and large netlink dumps In addition to in-kernel optimizations, will be nice to have a solution that reduces the burden on userspace. That will need a newer netlink dump format for fdbs. Considering all the changes needed, Nikolays patch seems less intrusive. From mboxrd@z Thu Jan 1 00:00:00 1970 From: roopa Subject: Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans Date: Wed, 26 Aug 2015 21:57:19 -0700 Message-ID: <55DE98AF.8000503@cumulusnetworks.com> References: <1440549295-3979-1-git-send-email-razor@blackwall.org> <20150825.194222.390859854071446877.davem@davemloft.net> <20150825.230641.773630246486190390.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , netdev@vger.kernel.org, vyasevic@redhat.com, toshiaki.makita1@gmail.com, stephen@networkplumber.org, bridge@lists.linux-foundation.org, wkok@cumulusnetworks.com To: Nikolay Aleksandrov Return-path: Received: from mail-pa0-f52.google.com ([209.85.220.52]:36308 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555AbbH0E5j (ORCPT ); Thu, 27 Aug 2015 00:57:39 -0400 Received: by pacgr6 with SMTP id gr6so11792308pac.3 for ; Wed, 26 Aug 2015 21:57:38 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 8/26/15, 4:33 AM, Nikolay Aleksandrov wrote: >> On Aug 25, 2015, at 11:06 PM, David Miller wro= te: >> >> From: Nikolay Aleksandrov >> Date: Tue, 25 Aug 2015 22:28:16 -0700 >> >>> Certainly, that should be done and I will look into it, but the >>> essence of this patch is a bit different. The problem here is not >>> the size of the fdb entries, it=E2=80=99s more the number of them -= having >>> 96000 entries (even if they were 1 byte ones) is just way too much >>> especially when the fdb hash size is small and static. We could wor= k >>> on making it dynamic though, but still these type of local entries >>> per vlan per port can easily be avoided with this option. >> 96000 bits can be stored in 12k. Get where I'm going with this? >> >> Look at the problem sideways. > Oh okay, I misunderstood your previous comment. I=E2=80=99ll look int= o that. > I just wanted to add the other problems we have had with keeping these=20 macs (mostly from userspace POV): - add/del netlink notification storms - and large netlink dumps In addition to in-kernel optimizations, will be nice to have a solution= =20 that reduces the burden on userspace. That will need a newer netlink=20 dump format for fdbs. Considering all the changes needed, Nikolays patc= h=20 seems less intrusive.