From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 27 Aug 2015 10:01:07 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:31592 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27007567AbbH0IBE2n015 (ORCPT ); Thu, 27 Aug 2015 10:01:04 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 80B8EDF75EEA1; Thu, 27 Aug 2015 09:00:56 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 27 Aug 2015 09:00:58 +0100 Received: from [192.168.154.168] (192.168.154.168) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.210.2; Thu, 27 Aug 2015 09:00:57 +0100 Subject: Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863] To: Joseph Myers , Mike Frysinger References: <1440563342-5411-1-git-send-email-vapier@gentoo.org> <20150826171017.GD3116@vapier> CC: , From: Markos Chandras Message-ID: <55DEC3B9.1070105@imgtec.com> Date: Thu, 27 Aug 2015 09:00:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150826171017.GD3116@vapier> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.168] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 49039 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Markos.Chandras@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 08/26/2015 06:10 PM, Mike Frysinger wrote: > On 26 Aug 2015 09:30, Joseph Myers wrote: >> On Wed, 26 Aug 2015, Mike Frysinger wrote: >>> Linux 3.13 added SIGSYS details to siginfo_t; update glibc's copy to >>> keep in sync with it. >>> >>> 2015-08-25 Mike Frysinger >>> >>> [BZ #18863] >>> * sysdeps/unix/sysv/linux/mips/bits/siginfo.h (siginfo_t): Add _sigsys. >>> (si_call_addr): Define. >>> (si_syscall): Define. >>> (si_arch): Define. >> >> OK. CC to linux-mips because I see that the MIPS implementation of >> copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so >> I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel. > > i'm getting reports of seccomp misbehavior on mips already which is what > started me down this glibc path. i suspect the original port was tested > against o32 kernels only. > -mike > I have recently tested mips64 n64/n32 with the testsuite from libseccomp and that led me to this fix https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9f161439e4104b641a7bfb9b89581d801159fec8 if you are aware of other problems (and perhaps a test to trigger them) that could be kernel related let me know -- markos From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:31592 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27007567AbbH0IBE2n015 (ORCPT ); Thu, 27 Aug 2015 10:01:04 +0200 Subject: Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863] References: <1440563342-5411-1-git-send-email-vapier@gentoo.org> <20150826171017.GD3116@vapier> From: Markos Chandras Message-ID: <55DEC3B9.1070105@imgtec.com> Date: Thu, 27 Aug 2015 09:00:57 +0100 MIME-Version: 1.0 In-Reply-To: <20150826171017.GD3116@vapier> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Joseph Myers , Mike Frysinger Cc: libc-alpha@sourceware.org, linux-mips@linux-mips.org Message-ID: <20150827080057.3y4g1CfHf6_7vZfebn75qE7tjDKLNDB9wuoiLT76reE@z> On 08/26/2015 06:10 PM, Mike Frysinger wrote: > On 26 Aug 2015 09:30, Joseph Myers wrote: >> On Wed, 26 Aug 2015, Mike Frysinger wrote: >>> Linux 3.13 added SIGSYS details to siginfo_t; update glibc's copy to >>> keep in sync with it. >>> >>> 2015-08-25 Mike Frysinger >>> >>> [BZ #18863] >>> * sysdeps/unix/sysv/linux/mips/bits/siginfo.h (siginfo_t): Add _sigsys. >>> (si_call_addr): Define. >>> (si_syscall): Define. >>> (si_arch): Define. >> >> OK. CC to linux-mips because I see that the MIPS implementation of >> copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so >> I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel. > > i'm getting reports of seccomp misbehavior on mips already which is what > started me down this glibc path. i suspect the original port was tested > against o32 kernels only. > -mike > I have recently tested mips64 n64/n32 with the testsuite from libseccomp and that led me to this fix https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9f161439e4104b641a7bfb9b89581d801159fec8 if you are aware of other problems (and perhaps a test to trigger them) that could be kernel related let me know -- markos