From: Jon Hunter <jonathanh@nvidia.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [RFC PATCH] PM / Domains: Ensure subdomain is not in use before removing
Date: Thu, 27 Aug 2015 12:47:11 +0100 [thread overview]
Message-ID: <55DEF8BF.6000503@nvidia.com> (raw)
In-Reply-To: <CAMuHMdUtnb1_e9v3U_iUT2qxTdacaVHY7tzbR_1kgykC+1MUyw@mail.gmail.com>
Hi Geert,
On 27/08/15 12:37, Geert Uytterhoeven wrote:
> Hi Jon,
>
> On Thu, Aug 27, 2015 at 11:21 AM, Jon Hunter <jonathanh@nvidia.com> wrote:
>> The function pm_genpd_remove_subdomain() removes a subdomain from a
>> generic PM domain, however, it does not check if the subdomain has any
>> slave domains or device attached before doing so. Therefore, add a test
>> to verify that the subdomain does not have any slave domains associated
>> or any device attached before removing.
>
> So far no-one ran into this, as there are no callers of
> pm_genpd_remove_subdomain() in mainline or -next.
>
> Do you plan to add a caller?
Yes exactly. However, given that the API was present I thought why not
fix it now or at least get some feedback on this.
I have also noticed that there is no function to remove a pm-domain (ie.
reverse of pm_genpd_init()). I assume that currently people add
pm-domains and never remove them, which makes sense, however the
scenario I am trying to solve is allowing the registering of pm-domains
to be deferred if something is not yet present (ie. a regulator).
Cheers
Jon
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
next prev parent reply other threads:[~2015-08-27 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 9:21 [RFC PATCH] PM / Domains: Ensure subdomain is not in use before removing Jon Hunter
2015-08-27 11:37 ` Geert Uytterhoeven
2015-08-27 11:47 ` Jon Hunter [this message]
2015-08-28 17:38 ` Kevin Hilman
2015-09-03 8:08 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DEF8BF.6000503@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=geert@linux-m68k.org \
--cc=khilman@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.