All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] libdm-iface: not output error message inside retry loops
Date: Thu, 27 Aug 2015 13:59:14 +0200	[thread overview]
Message-ID: <55DEFB92.5020106@redhat.com> (raw)
In-Reply-To: <1440664241-6149-1-git-send-email-lwang@suse.com>

Dne 27.8.2015 v 10:30 Liuhua Wang napsal(a):
>      To avoid noisy error message being output inside retry loops
>      in case of remove failure because device busy.
> ---

Hi

It's in fact made 'noisy' intentionally - we normally should detect whether 
retry makes sense - so  what are the conditions when you experience this problem ?

Common scenario:

The major reason for retry is 'unpredictable'  udev event processing
i.e. you run  'umount' -> fires watch-rule -> lvremove  could have failed - 
retry fixes this problem.


Regards

Zdenek



  reply	other threads:[~2015-08-27 11:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27  8:30 [PATCH] libdm-iface: not output error message inside retry loops Liuhua Wang
2015-08-27 11:59 ` Zdenek Kabelac [this message]
2015-08-28  2:58   ` Liuhua Wang
2015-08-28 10:16     ` Zdenek Kabelac
2015-08-28 11:24       ` Liuhua Wang
2015-08-28 11:52         ` Zdenek Kabelac
2015-08-31  8:39           ` Liuhua Wang
2015-08-31  9:30             ` Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DEFB92.5020106@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.