From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.s-osg.org (lists.s-osg.org. [54.187.51.154]) by gmr-mx.google.com with ESMTP id ff6si296380pac.2.2015.08.27.05.23.21 for ; Thu, 27 Aug 2015 05:23:21 -0700 (PDT) Subject: [rtc-linux] Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers To: Andrey Ryabinin References: <1440671672-26590-1-git-send-email-javier@osg.samsung.com> Cc: LKML , Luis de Bethencourt , linux-samsung-soc@vger.kernel.org, Alessandro Zummo , Sangbeom Kim , Linus Walleij , Alexandre Belloni , Krzysztof Kozlowski , rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org From: Javier Martinez Canillas Message-ID: <55DF0133.2070009@osg.samsung.com> Date: Thu, 27 Aug 2015 14:23:15 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hello Andrey, On 08/27/2015 02:20 PM, Andrey Ryabinin wrote: > 2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas : >> These platform drivers have a platform device ID table but the module >> alias information is not created so module autoloading will not work. >> >> Signed-off-by: Javier Martinez Canillas >> >> --- >> >> drivers/rtc/rtc-ab8500.c | 1 + >> drivers/rtc/rtc-max8997.c | 1 + >> drivers/rtc/rtc-s5m.c | 1 + >> 3 files changed, 3 insertions(+) >> >> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c >> index 133d2e2e1a25..8537d1e3a995 100644 >> --- a/drivers/rtc/rtc-ab8500.c >> +++ b/drivers/rtc/rtc-ab8500.c >> @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = { >> { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, }, >> { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, }, > > Completely irrelevant, but this array should have an empty terminating element. > You are right, it's missing a sentinel indeed. But that change should be done in a separate patch. >> }; >> +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids); >> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers Date: Thu, 27 Aug 2015 14:23:15 +0200 Message-ID: <55DF0133.2070009@osg.samsung.com> References: <1440671672-26590-1-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from lists.s-osg.org ([54.187.51.154]:60362 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbbH0MXV (ORCPT ); Thu, 27 Aug 2015 08:23:21 -0400 In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Andrey Ryabinin Cc: LKML , Luis de Bethencourt , linux-samsung-soc@vger.kernel.org, Alessandro Zummo , Sangbeom Kim , Linus Walleij , Alexandre Belloni , Krzysztof Kozlowski , rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org Hello Andrey, On 08/27/2015 02:20 PM, Andrey Ryabinin wrote: > 2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas : >> These platform drivers have a platform device ID table but the module >> alias information is not created so module autoloading will not work. >> >> Signed-off-by: Javier Martinez Canillas >> >> --- >> >> drivers/rtc/rtc-ab8500.c | 1 + >> drivers/rtc/rtc-max8997.c | 1 + >> drivers/rtc/rtc-s5m.c | 1 + >> 3 files changed, 3 insertions(+) >> >> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c >> index 133d2e2e1a25..8537d1e3a995 100644 >> --- a/drivers/rtc/rtc-ab8500.c >> +++ b/drivers/rtc/rtc-ab8500.c >> @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = { >> { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, }, >> { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, }, > > Completely irrelevant, but this array should have an empty terminating element. > You are right, it's missing a sentinel indeed. But that change should be done in a separate patch. >> }; >> +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids); >> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier@osg.samsung.com (Javier Martinez Canillas) Date: Thu, 27 Aug 2015 14:23:15 +0200 Subject: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers In-Reply-To: References: <1440671672-26590-1-git-send-email-javier@osg.samsung.com> Message-ID: <55DF0133.2070009@osg.samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Andrey, On 08/27/2015 02:20 PM, Andrey Ryabinin wrote: > 2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas : >> These platform drivers have a platform device ID table but the module >> alias information is not created so module autoloading will not work. >> >> Signed-off-by: Javier Martinez Canillas >> >> --- >> >> drivers/rtc/rtc-ab8500.c | 1 + >> drivers/rtc/rtc-max8997.c | 1 + >> drivers/rtc/rtc-s5m.c | 1 + >> 3 files changed, 3 insertions(+) >> >> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c >> index 133d2e2e1a25..8537d1e3a995 100644 >> --- a/drivers/rtc/rtc-ab8500.c >> +++ b/drivers/rtc/rtc-ab8500.c >> @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = { >> { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, }, >> { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, }, > > Completely irrelevant, but this array should have an empty terminating element. > You are right, it's missing a sentinel indeed. But that change should be done in a separate patch. >> }; >> +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids); >> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America