Re: [PATCH 7/7] selftests: breakpoints: fix installing error on the architecture except x86

[Shuah Khan <shuahkh@osg.samsung.com>]

On 08/14/2015 07:43 AM, Bamvor Jian Zhang wrote:
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>

Hi Bamvor,

Could you please add commit log with more details on the error you
are seeing. I would like to get this patch into kselftest next for
4.3 soon

thanks,
-- Shuah
> ---
>  tools/testing/selftests/breakpoints/Makefile | 16 +++-------------
>  1 file changed, 3 insertions(+), 13 deletions(-)
> 
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 1822356..d27108b 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -1,22 +1,12 @@
>  # Taken from perf makefile
>  uname_M := $(shell uname -m 2>/dev/null || echo not)
> -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
> -ifeq ($(ARCH),i386)
> -        ARCH := x86
> -endif
> -ifeq ($(ARCH),x86_64)
> -	ARCH := x86
> -endif
> +ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>  
> -
> -all:
>  ifeq ($(ARCH),x86)
> -	gcc breakpoint_test.c -o breakpoint_test
> -else
> -	echo "Not an x86 target, can't build breakpoints selftests"
> +TEST_PROGS := breakpoint_test
>  endif
>  
> -TEST_PROGS := breakpoint_test
> +all:
>  
>  include ../lib.mk
>  
> 


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978