Re: [Qemu-devel] [PATCH v8 05/11] move out net queue structs define

[Thomas Huth <thuth@redhat.com>]

Maybe add a short comment why/where this is needed later?

On 26/08/15 11:59, Yang Hongyang wrote:
> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
> ---
>  include/net/queue.h | 19 +++++++++++++++++++
>  net/queue.c         | 19 -------------------
>  2 files changed, 19 insertions(+), 19 deletions(-)
> 
> diff --git a/include/net/queue.h b/include/net/queue.h
> index fc02b33..1d65e47 100644
> --- a/include/net/queue.h
> +++ b/include/net/queue.h
> @@ -31,6 +31,25 @@ typedef struct NetQueue NetQueue;
>  
>  typedef void (NetPacketSent) (NetClientState *sender, ssize_t ret);
>  
> +struct NetPacket {
> +    QTAILQ_ENTRY(NetPacket) entry;
> +    NetClientState *sender;
> +    unsigned flags;
> +    int size;
> +    NetPacketSent *sent_cb;
> +    uint8_t data[0];
> +};
> +
> +struct NetQueue {
> +    void *opaque;
> +    uint32_t nq_maxlen;
> +    uint32_t nq_count;
> +
> +    QTAILQ_HEAD(packets, NetPacket) packets;
> +
> +    unsigned delivering:1;
> +};
> +
>  #define QEMU_NET_PACKET_FLAG_NONE  0
>  #define QEMU_NET_PACKET_FLAG_RAW  (1<<0)
>  
> diff --git a/net/queue.c b/net/queue.c
> index ebbe2bb..1499479 100644
> --- a/net/queue.c
> +++ b/net/queue.c
> @@ -39,25 +39,6 @@
>   * unbounded queueing.
>   */
>  
> -struct NetPacket {
> -    QTAILQ_ENTRY(NetPacket) entry;
> -    NetClientState *sender;
> -    unsigned flags;
> -    int size;
> -    NetPacketSent *sent_cb;
> -    uint8_t data[0];
> -};
> -
> -struct NetQueue {
> -    void *opaque;
> -    uint32_t nq_maxlen;
> -    uint32_t nq_count;
> -
> -    QTAILQ_HEAD(packets, NetPacket) packets;
> -
> -    unsigned delivering : 1;
> -};
> -
>  NetQueue *qemu_new_net_queue(void *opaque)
>  {
>      NetQueue *queue;

Reviewed-by: Thomas Huth <thuth@redhat.com>