From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86: wrap kexec feature with CONFIG_KEXEC
Date: Thu, 27 Aug 2015 16:39:29 +0100
Message-ID: <55DF2F31.4020900@citrix.com>
References: <1440686870-19104-1-git-send-email-jonathan.creekmore@gmail.com>
	<55DF2B4F.9000802@citrix.com>
	<55DF4A0A020000780009D859@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=674cdb2fc=Andrew.Cooper3@citrix.com>)
	id 1ZUzHE-00084F-08
	for xen-devel@lists.xenproject.org; Thu, 27 Aug 2015 15:39:44 +0000
In-Reply-To: <55DF4A0A020000780009D859@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Jonathan Creekmore <jonathan.creekmore@gmail.com>
Cc: xen-devel@lists.xenproject.org, keir@xen.org, david.vrabel@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 27/08/15 16:34, Jan Beulich wrote:
>>>> On 27.08.15 at 17:22, <andrew.cooper3@citrix.com> wrote:
>> On 27/08/15 15:47, Jonathan Creekmore wrote:
>>> @@ -812,7 +816,11 @@ ENTRY(hypercall_args_table)
>>>          .byte 2 /* do_hvm_op            */
>>>          .byte 1 /* do_sysctl            */  /* 35 */
>>>          .byte 1 /* do_domctl            */
>>> +#ifdef CONFIG_KEXEC
>>>          .byte 2 /* do_kexec             */
>>> +#else
>>> +        .byte 0 /* do_ni_hypercall      */
>>> +#endif
>> These changes will corrupt guest registers in debug builds.
> It's quite the other way around:

Ah yes - of course.  Sorry for the noise.

~Andrew