Re: [Qemu-devel] [PATCH] monitor: allow object_del & device_del to accept QOM paths

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]

On 08/27/2015 09:37 AM, Daniel P. Berrange wrote:
> Currently both object_del and device_del require that the
> client provide the object/device short ID. While user
> creatable objects require an ID to be provided at time of
> creation, qdev devices may be created without giving an
> ID. The only unique identifier they would then have is the
> QOM object path.
> 
> Allowing device_del to accept an object path ensures all
> devices are deletable regardless of whether they have an
> ID.
> 
>  (qemu) device_add usb-mouse
>  (qemu) qom-list /machine/peripheral-anon
>  device[0] (child<usb-mouse>)
>  type (string)
>  (qemu) device_del /machine/peripheral-anon/device[0]
> 
> Although objects require an ID to be provided upfront,
> there may be cases where the client would prefer to
> use QOM paths when deleting.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  hmp-commands.hx |  6 ++++--
>  qdev-monitor.c  | 14 +++++++++-----
>  qmp-commands.hx | 17 +++++++++++++----
>  qmp.c           | 10 +++++++---
>  4 files changed, 33 insertions(+), 14 deletions(-)

Might also want to touch qapi-schema.json for consistent documentation
of the @id parameter (our goal is for qmp-commands.hx to go away some
day; and while we can merge contents at that time, it's nicer to keep
them in sync now)

Reviewed-by: Eric Blake <eblake@redhat.com

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]