From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46326)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1ZUzpe-0004Gx-TQ
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 12:15:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1ZUzpb-0002SX-LP
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 12:15:18 -0400
Received: from mx2.parallels.com ([199.115.105.18]:59328)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1ZUzpb-0002SP-GG
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 12:15:15 -0400
References: <1440632099-5169-1-git-send-email-marcandre.lureau@redhat.com>
	<1440632099-5169-5-git-send-email-marcandre.lureau@redhat.com>
	<55DED4D6.8000508@openvz.org> <55DED5B8.7090901@openvz.org>
	<CAJ+F1CLoX1piRRxBCXyDpWazB+e_BPU6Gwmc3ktTCaA0S3TaRA@mail.gmail.com>
From: "Denis V. Lunev" <den-lists@parallels.com>
Message-ID: <55DF3788.9020104@parallels.com>
Date: Thu, 27 Aug 2015 19:15:04 +0300
MIME-Version: 1.0
In-Reply-To: <CAJ+F1CLoX1piRRxBCXyDpWazB+e_BPU6Gwmc3ktTCaA0S3TaRA@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v4 04/13] qga: make split_list() return
 allocated strings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@gmail.com>, "Denis V.
	Lunev" <den@openvz.org>
Cc: QEMU <qemu-devel@nongnu.org>, Michael Roth <mdroth@linux.vnet.ibm.com>

On 08/27/2015 05:30 PM, Marc-André Lureau wrote:
> Hi
>
> On Thu, Aug 27, 2015 at 11:17 AM, Denis V. Lunev <den@openvz.org> wrote:
>> why not to
>> __str = g_strsplit(str, delim, -1);
>>>> +    strv = g_strsplit(str, delim, -1);
>>>> +    for (i = 0; strv[i]; i++) {
>>>> +        list = g_list_prepend(list, strv[i]);
>>>>        }
>>>> +    g_free(strv);
>> g_free(__str);
>>
>> This will remove all burden from callers.
>> You will be able to use const char * as argument too.
>
> Sorry, I don't understand, could you propose a different patch?
>
you are right, me wrong :) I have mis-read the code.
This one is perfect.

Reviewed-by: Denis V. Lunev <den@openvz.org>