All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Gordon <david.s.gordon@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] doc: drm: Fix mis-spelling of i915_guc_submission includes
Date: Thu, 27 Aug 2015 19:15:18 +0100	[thread overview]
Message-ID: <55DF53B6.8060206@intel.com> (raw)
In-Reply-To: <1440423681-11825-1-git-send-email-graham.whaley@linux.intel.com>

On 24/08/15 14:41, Graham Whaley wrote:
> In commit
>   d1675198e: drm/i915: Integrate GuC-based command submission
>
> the drm.tmpl include lines reference the intel_guc_submission.c but the
> patch adds the file i915_guc_submission.c. drm.tmpl fails to build with:
>   docproc: .//drivers/gpu/drm/i915/intel_guc_submission.c:
>    No such file or directory
>
> Change the file reference to the actual file.
>
> Signed-off-by: Graham Whaley <graham.whaley@linux.intel.com>
> ---
> This looks/feels like the right fix to me, but I am not intimate enough
> with the APIs to verify for sure - some confirmation would be good.
>
>   Documentation/DocBook/drm.tmpl | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index a01fca9..66bc646 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -4160,8 +4160,8 @@ int num_ioctls;</synopsis>
>         </sect2>
>         <sect2>
>           <title>GuC Client</title>
> -!Pdrivers/gpu/drm/i915/intel_guc_submission.c GuC-based command submissison
> -!Idrivers/gpu/drm/i915/intel_guc_submission.c
> +!Pdrivers/gpu/drm/i915/i915_guc_submission.c GuC-based command submissison
> +!Idrivers/gpu/drm/i915/i915_guc_submission.c
>         </sect2>
>       </sect1>

Yes, that file got renamed late in development, and obviously the 
drm.tmpl entry wasn't updated to match.

Reviewed-by: Dave Gordon <david.s.gordon@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2015-08-27 18:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24 13:41 [PATCH] doc: drm: Fix mis-spelling of i915_guc_submission includes Graham Whaley
2015-08-25  9:24 ` Daniel Vetter
2015-08-27 18:15 ` Dave Gordon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DF53B6.8060206@intel.com \
    --to=david.s.gordon@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.