From: Eric Blake <eblake@redhat.com>
To: "Christian Rößner" <c@roessner.co>, "Jeff Cody" <jcody@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-discuss@nongnu.org
Subject: Re: [Qemu-devel] KVM guest gets aborted if blockcommit is called
Date: Thu, 27 Aug 2015 14:15:51 -0600 [thread overview]
Message-ID: <55DF6FF7.5050906@redhat.com> (raw)
In-Reply-To: <0F34FD04-48A3-4FAD-853B-A2CBE978902E@roessner.co>
[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]
On 08/27/2015 02:01 PM, Christian Rößner wrote:
>>>>
>>>> I think you may be running into a bug that is fixed by a recent patch
>>>> (after v2.4.0):
>>>>
>>>> commit e424aff5f307227b1c2512bbb8ece891bb895cef
>>>> Author: Kevin Wolf <kwolf@redhat.com>
>>>> Date: Thu Aug 13 10:41:50 2015 +0200
>>>>
>>>> mirror: Fix coroutine reentrance
>>>>
>>>>
>>>> Could you retry with qemu.git/master, and see if that fixes the issue
>>>> you are seeing?
>>>
>>> Until now, everything looks perfectly. No issues. Backup is running smoothly.
>>>
>>> Thanks very much. If nothing changes until tonight, I am going to close the bug report.
>>>
>>
>> Christian,
>>
>> Great to hear, thanks for the follow-up.
>
> Just a final result:
>
> As I use libvirt with qemu, I used the blockcommit feature with libvirt. Running blockcommit directly with --wait --active --pivot, it may happen that the pivot fails, because the blockcommit wasn't already ready to pivot. But I do not know, if this is libvirt related or qemu. Splitting it into blockcommit and blockjob, everything works like a charm. So I have a working solution now. Thanks very much for your help and feedback.
Which version of libvirt? There was a bug up until 1.2.18 where older
libvirt got thrown off by newer qemu returning a status with 0 progress
but equal to the block job size, and libvirt interpreting it as job
complete with a result of failing the command; splitting the job into
distinct parts was indeed the right workaround as it prevented hitting
the window. See libvirt commit eae5924
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-08-27 20:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 6:02 [Qemu-devel] KVM guest gets aborted if blockcommit is called Christian Rößner
2015-08-26 8:08 ` Christian Rößner
2015-08-26 13:25 ` Jeff Cody
2015-08-26 14:53 ` Christian Rößner
2015-08-27 9:26 ` Christian Rößner
2015-08-27 12:34 ` Jeff Cody
2015-08-27 20:01 ` Christian Rößner
2015-08-27 20:15 ` Eric Blake [this message]
2015-08-27 20:22 ` Christian Rößner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DF6FF7.5050906@redhat.com \
--to=eblake@redhat.com \
--cc=c@roessner.co \
--cc=jcody@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-discuss@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.